Crash handler error issue fixed (#61)

* Crash handler error stack parsing issue fixed for React-Native version >= 0.64

* Changlelog updated

* Typo fix in Changelog

Author: ijunaid

CHANGELOG.md

@@ -1,3 +1,8 @@
+## 20.11.10
+* Error/crash stack parsing issue fixed for React-Native version >= 0.64
+* Underlying android SDK is 20.11.10
+* Underlying iOS SDK version is 20.11.1
+
 ## 20.11.9
 * Automatic crash reporting issue fixed.
 * Android background session logging issue fixed.

Countly.js

@@ -4,7 +4,7 @@
  * @Countly
  */
 
-import {
+ import {
     Platform,
     NativeModules,
     NativeEventEmitter
@@ -308,31 +308,34 @@ Countly.enableCrashReporting = async function(){
         }
         var previousHandler = ErrorUtils.getGlobalHandler();
         ErrorUtils.setGlobalHandler(function (error, isFatal) {
-            var jsStackTrace = parseErrorStackLib(error);
-            var fname = jsStackTrace[0].file;
-            if (fname.startsWith("http")) {
-                var chunks = fname.split("/");
-                fname = chunks[chunks.length-1].split("?")[0];
+            let jsStackTrace = Countly.getStackTrace(error);
+            let errorTitle;
+            let stackArr;
+            if(jsStackTrace == null) {
+                errorTitle = error.name;
+                stackArr = error.stack;
             }
-            var errorTitle = `${error.name} (${jsStackTrace[0].methodName}@${fname})`;
-            const regExp = "(.*)(@?)http(s?).*/(.*)\\?(.*):(.*):(.*)";
-            const stackArr = error.stack.split("\n").map(row => {
-                row = row.trim();
-                if (!row.includes("http")) return row;
-                else {
-                    const matches = row.match(regExp);
-                    return matches && matches.length == 8 ? `${matches[1]}${matches[2]}${matches[4]}(${matches[6]}:${matches[7]})` : row;
+            else {
+                var fname = jsStackTrace[0].file;
+                if (fname.startsWith("http")) {
+                    var chunks = fname.split("/");
+                    fname = chunks[chunks.length-1].split("?")[0];
                 }
-            })
-            const stack = stackArr.join("\n");
-            if (Platform.OS.match("android")) {
-                CountlyReactNative.logJSException(errorTitle, error.message.trim(), stack);
-            }
-            else if (Platform.OS.match("ios")) {
-                const errMessage = `[React] ${errorTitle}: ${error.message}`;
-                const errStack = error.message + "\n" + stack;
-                CountlyReactNative.logJSException(errorTitle, errMessage, errStack);
+                errorTitle = `${error.name} (${jsStackTrace[0].methodName}@${fname})`;
+                const regExp = "(.*)(@?)http(s?).*/(.*)\\?(.*):(.*):(.*)";
+                stackArr = error.stack.split("\n").map(row => {
+                    row = row.trim();
+                    if (!row.includes("http")) return row;
+                    else {
+                        const matches = row.match(regExp);
+                        return matches && matches.length == 8 ? `${matches[1]}${matches[2]}${matches[4]}(${matches[6]}:${matches[7]})` : row;
+                    }
+                })
+                stackArr = stackArr.join("\n");
             }
+            
+            CountlyReactNative.logJSException(errorTitle, error.message.trim(), stackArr);
+            
             if (previousHandler) {
                 previousHandler(error, isFatal);
             }
@@ -341,6 +344,26 @@ Countly.enableCrashReporting = async function(){
     Countly.isCrashReportingEnabled = true;
 }
 
+Countly.getStackTrace = (e) => {
+    let jsStackTrace = null;
+    try {
+        if (Platform.hasOwnProperty("constants")) {
+            // RN version >= 0.63
+            if (Platform.constants.reactNativeVersion.minor >= 64)
+              // RN version >= 0.64
+              jsStackTrace = parseErrorStackLib(e.stack);
+            // RN version == 0.63
+            else jsStackTrace = parseErrorStackLib(e);
+          }
+          // RN version < 0.63
+          else jsStackTrace = parseErrorStackLib(e);
+    }
+    catch (e) {
+       // console.log(e.message);
+     }
+    return jsStackTrace;
+  };
+
 Countly.addCrashLog = function(crashLog){
     CountlyReactNative.addCrashLog([crashLog]);
 }

CountlyReactNative.podspec

@@ -1,6 +1,6 @@
 Pod::Spec.new do |s|
   s.name = 'CountlyReactNative'
-  s.version = '20.11.9'
+  s.version = '20.11.10'
   s.license = {
     :type => 'COMMUNITY',
     :text => <<-LICENSE

android/src/main/java/ly/count/android/sdk/react/CountlyReactNative.java

@@ -74,7 +74,7 @@ public String toString(){
 public class CountlyReactNative extends ReactContextBaseJavaModule implements LifecycleEventListener {
 
     public static final String TAG = "CountlyRNPlugin";
-    private String COUNTLY_RN_SDK_VERSION_STRING = "20.11.9";
+    private String COUNTLY_RN_SDK_VERSION_STRING = "20.11.10";
     private String COUNTLY_RN_SDK_NAME = "js-rnb-android";
 
     private static CountlyConfig config = new CountlyConfig();

example/install.sh

@@ -11,7 +11,7 @@ rm App.js
 curl https://raw.githubusercontent.com/Countly/countly-sdk-react-native-bridge/master/example/App.js --output App.js
 curl https://raw.githubusercontent.com/Countly/countly-sdk-react-native-bridge/master/example/Example.js --output Example.js
 
-yarn add [email protected].9
+yarn add [email protected].10
 
 cd ./ios
 pod install

ios/src/CountlyReactNative.m

@@ -21,7 +21,7 @@ @interface CountlyFeedbackWidget ()
 + (CountlyFeedbackWidget *)createWithDictionary:(NSDictionary *)dictionary;
 @end
 
-NSString* const kCountlyReactNativeSDKVersion = @"20.11.9";
+NSString* const kCountlyReactNativeSDKVersion = @"20.11.10";
 NSString* const kCountlyReactNativeSDKName = @"js-rnb-ios";
 
 CountlyConfig* config = nil;

package.json

@@ -1,6 +1,6 @@
 {
   "name": "countly-sdk-react-native-bridge",
-  "version": "20.11.9",
+  "version": "20.11.10",
   "author": "Countly <[email protected]> (https://count.ly/)",
   "bugs": {
     "url": "https://github.com/Countly/countly-sdk-react-native-bridge/issues"