Skip to content

Commit 4d55f2b

Browse files
committed
fix: review comments
1 parent f7dddc6 commit 4d55f2b

File tree

2 files changed

+15
-18
lines changed

2 files changed

+15
-18
lines changed

frontend/src/modules/member/pages/member-list-page.vue

Lines changed: 6 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -148,13 +148,12 @@ const queryParams = ref({
148148
const membersQueryKey = computed(() => [
149149
TanstackKey.MEMBERS_LIST,
150150
selectedProjectGroup.value?.id,
151-
{
152-
search: queryParams.value.search,
153-
offset: queryParams.value.offset,
154-
limit: queryParams.value.limit,
155-
orderBy: queryParams.value.orderBy,
156-
segments: selectedProjectGroup.value?.id ? [selectedProjectGroup.value.id] : [],
157-
},
151+
[queryParams.value.search,
152+
queryParams.value.offset,
153+
queryParams.value.limit,
154+
queryParams.value.orderBy,
155+
selectedProjectGroup.value?.id ? [selectedProjectGroup.value.id] : [],
156+
],
158157
]);
159158
160159
// Query for members list with caching

frontend/src/modules/organization/pages/organization-list-page.vue

Lines changed: 9 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -45,7 +45,7 @@
4545
v-if="hasPermission(LfPermission.organizationCreate)"
4646
type="primary"
4747
size="medium"
48-
@click="organizationCreate = true"
48+
@click="isOrganizationCreateModalOpen = true"
4949
>
5050
Add organization
5151
</lf-button>
@@ -77,12 +77,12 @@
7777
:is-page-loading="loading"
7878
:is-table-loading="tableLoading"
7979
@update:pagination="onPaginationChange"
80-
@on-add-organization="organizationCreate = true"
80+
@on-add-organization="isOrganizationCreateModalOpen = true"
8181
/>
8282
</div>
8383
</app-page-wrapper>
8484

85-
<lf-organization-add v-if="organizationCreate" v-model="organizationCreate" />
85+
<lf-organization-add v-if="isOrganizationCreateModalOpen" v-model="isOrganizationCreateModalOpen" />
8686
</template>
8787

8888
<script setup lang="ts">
@@ -115,7 +115,7 @@ const { buildApiFilter } = filterApiService();
115115
const organizationStore = useOrganizationStore();
116116
const { filters } = storeToRefs(organizationStore);
117117
118-
const organizationCreate = ref(false);
118+
const isOrganizationCreateModalOpen = ref(false);
119119
120120
const organizationFilter = ref<InstanceType<typeof LfFilter> | null>(null);
121121
@@ -145,13 +145,11 @@ const queryParams = ref({
145145
const organizationsQueryKey = computed(() => [
146146
TanstackKey.ORGANIZATIONS_LIST,
147147
selectedProjectGroup.value?.id,
148-
{
149-
search: queryParams.value.search,
150-
offset: queryParams.value.offset,
151-
limit: queryParams.value.limit,
152-
orderBy: queryParams.value.orderBy,
153-
segments: selectedProjectGroup.value?.id ? [selectedProjectGroup.value.id] : [],
154-
},
148+
queryParams.value.search,
149+
queryParams.value.offset,
150+
queryParams.value.limit,
151+
queryParams.value.orderBy,
152+
selectedProjectGroup.value?.id ? [selectedProjectGroup.value.id] : [],
155153
]);
156154
157155
// Query for organizations list with caching

0 commit comments

Comments
 (0)