refactor: remove GCP tags validation and improve type safety

Remove custom validation that prevented GCP configurations from using
tags filters. Improve type safety in selector conversion by adding
proper type checking for region and tags list values instead of
unsafe type assertions.

- Remove ResourceWithValidateConfig interface and ValidateConfig method
- Add type checking for region and tags list conversions
- Clean up struct field alignment in tests

Author: ffalor

internal/cloud_security_group/cloud_security_group.go

@@ -29,10 +29,9 @@ import (
 
 // Ensure the implementation satisfies the expected interfaces.
 var (
-	_ resource.Resource                     = &cloudSecurityGroupResource{}
-	_ resource.ResourceWithConfigure        = &cloudSecurityGroupResource{}
-	_ resource.ResourceWithImportState      = &cloudSecurityGroupResource{}
-	_ resource.ResourceWithValidateConfig   = &cloudSecurityGroupResource{}
+	_ resource.Resource                = &cloudSecurityGroupResource{}
+	_ resource.ResourceWithConfigure   = &cloudSecurityGroupResource{}
+	_ resource.ResourceWithImportState = &cloudSecurityGroupResource{}
 )
 
 // cloudSecurityGroupScopes defines the required API scopes for Cloud Security Groups.
@@ -346,46 +345,6 @@ func (r *cloudSecurityGroupResource) Configure(
 	r.client = client
 }
 
-// ValidateConfig validates the resource configuration.
-func (r *cloudSecurityGroupResource) ValidateConfig(
-	ctx context.Context,
-	req resource.ValidateConfigRequest,
-	resp *resource.ValidateConfigResponse,
-) {
-	var config cloudSecurityGroupResourceModel
-	resp.Diagnostics.Append(req.Config.Get(ctx, &config)...)
-	if resp.Diagnostics.HasError() {
-		return
-	}
-
-	// Validate that GCP configuration does not use tags filter
-	if !config.GCP.IsNull() && !config.GCP.IsUnknown() {
-		var gcpConfig cloudProviderConfigModel
-		resp.Diagnostics.Append(config.GCP.As(ctx, &gcpConfig, basetypes.ObjectAsOptions{})...)
-		if resp.Diagnostics.HasError() {
-			return
-		}
-
-		if !gcpConfig.Filters.IsNull() && !gcpConfig.Filters.IsUnknown() {
-			// Extract filters attributes to check for tags
-			filterValues := gcpConfig.Filters.Attributes()
-
-			// Check if tags field exists and has values
-			if tagsValue, ok := filterValues["tags"]; ok && !tagsValue.IsNull() {
-				var tags []string
-				resp.Diagnostics.Append(tagsValue.(types.List).ElementsAs(ctx, &tags, false)...)
-				if len(tags) > 0 {
-					resp.Diagnostics.AddAttributeError(
-						path.Root("gcp").AtName("filters").AtName("tags"),
-						"Invalid Configuration",
-						"GCP cloud resources do not support tag filtering. Remove the tags filter from the GCP configuration.",
-					)
-				}
-			}
-		}
-	}
-}
-
 // Create creates the resource and sets the initial Terraform state.
 func (r *cloudSecurityGroupResource) Create(
 	ctx context.Context,
@@ -772,15 +731,31 @@ func (r *cloudSecurityGroupResource) convertSelectorsToAPI(
 			// Extract region if present
 			if regionValue, ok := filterValues["region"]; ok && !regionValue.IsNull() {
 				var regions []string
-				diags.Append(regionValue.(types.List).ElementsAs(ctx, &regions, false)...)
+				regionList, ok := regionValue.(types.List)
+				if !ok {
+					diags.AddError(
+						"Invalid Type",
+						"Expected region to be a list type.",
+					)
+					return nil, diags
+				}
+				diags.Append(regionList.ElementsAs(ctx, &regions, false)...)
 				apiFilters.Region = regions
 			}
 
 			// Extract tags if present and includeTags is true
 			if includeTags {
 				if tagsValue, ok := filterValues["tags"]; ok && !tagsValue.IsNull() {
 					var tags []string
-					diags.Append(tagsValue.(types.List).ElementsAs(ctx, &tags, false)...)
+					tagsList, ok := tagsValue.(types.List)
+					if !ok {
+						diags.AddError(
+							"Invalid Type",
+							"Expected tags to be a list type.",
+						)
+						return nil, diags
+					}
+					diags.Append(tagsList.ElementsAs(ctx, &tags, false)...)
 					apiFilters.Tags = tags
 				}
 			}

internal/cloud_security_group/cloud_security_group_test.go

@@ -21,14 +21,14 @@ type groupConfig struct {
 	Owners         []string
 
 	// Cloud provider configs
-	AWSAccountIDs    []string
-	AWSRegions       []string
-	AWSTags          []string
-	AzureAccountIDs  []string
-	AzureRegions     []string
-	AzureTags        []string
-	GCPAccountIDs    []string
-	GCPRegions       []string
+	AWSAccountIDs   []string
+	AWSRegions      []string
+	AWSTags         []string
+	AzureAccountIDs []string
+	AzureRegions    []string
+	AzureTags       []string
+	GCPAccountIDs   []string
+	GCPRegions      []string
 
 	// Image selectors
 	Images []imageSelector