Skip to content

Commit 80e7d81

Browse files
committed
fixing some jet stuff and bumping reference finite elements version.
1 parent e71ea77 commit 80e7d81

File tree

4 files changed

+8
-10
lines changed

4 files changed

+8
-10
lines changed

Project.toml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,7 @@
11
name = "FiniteElementContainers"
22
uuid = "d08262e4-672f-4e7f-a976-f2cea5767631"
33
authors = ["Craig M. Hamel <[email protected]> and contributors"]
4-
version = "0.5.6"
4+
version = "0.5.7"
55

66
[deps]
77
Atomix = "a9b6321e-bd34-4604-b9c9-b65b8de01458"

src/Meshes.jl

Lines changed: 3 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -56,11 +56,9 @@ function num_dimensions end
5656
$(TYPEDSIGNATURES)
5757
Dummy method to be overriden for specific mesh file format
5858
"""
59-
function num_nodes end
60-
"""
61-
$(TYPEDSIGNATURES)
62-
Dummy method to be overriden for specific mesh file format
63-
"""
59+
function num_nodes(mesh::AbstractMesh)
60+
@assert false "This method needs to overriden in extensions!"
61+
end
6462

6563
"""
6664
$(TYPEDSIGNATURES)

src/function_spaces/FunctionSpaces.jl

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -29,7 +29,7 @@ reference_element(fspace::FunctionSpace) = fspace.ref_fe
2929
"""
3030
$(TYPEDSIGNATURES)
3131
"""
32-
num_dimensions(fspace::FunctionSpace) = ReferenceFiniteElements.dimension(fspace.ref_fe.ref_fe_type)
32+
num_dimensions(fspace::FunctionSpace) = ReferenceFiniteElements.dimension(fspace.ref_fe.element)
3333
"""
3434
$(TYPEDSIGNATURES)
3535
"""

test/runtests.jl

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -32,6 +32,6 @@ end
3232
end
3333

3434
# getting an error from FileMesh.num_nodes for some reason. No method
35-
# @testset ExtendedTestSet "JET" begin
36-
# JET.test_package(FiniteElementContainers; target_defined_modules=true)
37-
# end
35+
@testset ExtendedTestSet "JET" begin
36+
JET.test_package(FiniteElementContainers; target_defined_modules=true)
37+
end

0 commit comments

Comments
 (0)