-
Notifications
You must be signed in to change notification settings - Fork 28
Description
Recent additions start specifying timeouts to apply either on a specific request or in general at the script entry point.
- rf_logs.py specifies a timeout of 30 when instantiating the Redfish object
- All other scripts specify a timeout of 15 when instantiating the Redfish object
- Multipart push update applies 2 seconds per MB (determined from the file size)
Original times were a bit more strict (5 seconds for all scripts, and approximately 1 second for every 3 MB for a push update).
15 seconds could be a bit aggressive for most usage and we could likely bring this back down to 5 seconds. However, the log entry reading could easily go past this in some cases, so maybe we could push the 30 seconds down to the log entry retrieval itself.
I don't have a good sense of a "right" answer for the multipart update one; file sizes can be large, and should we penalize fast networks for being accommodating of slower networks? Is there a better solution? In Ansible, a user has to specify the timeout, but I prefer to avoid adding more options.