WAF for curl requests/partial json/libddwaf v2

[cataphract]

Description

Reviewer checklist

• Test coverage seems ok.
• Appropriate labels assigned.

[pr-commenter]

Benchmarks [ tracer ]

Benchmark execution time: 2025-11-21 13:03:32

Comparing candidate commit 2d9bc56 in PR branch glopes/appsec-curl with baseline commit 4485a51 in branch master.

Found 1 performance improvements and 8 performance regressions! Performance is the same for 185 metrics, 0 unstable metrics.

scenario:ComposerTelemetryBench/benchTelemetryParsing

• 🟥 execution_time [+0.662µs; +1.538µs] or [+6.243%; +14.512%]

scenario:EmptyFileBench/benchEmptyFileDdprof-opcache

• 🟥 execution_time [+126.439µs; +307.801µs] or [+3.311%; +8.061%]

scenario:MessagePackSerializationBench/benchMessagePackSerialization

• 🟥 execution_time [+2.550µs; +3.110µs] or [+2.481%; +3.026%]

scenario:SamplingRuleMatchingBench/benchRegexMatching1

• 🟥 execution_time [+46.966ns; +100.834ns] or [+3.994%; +8.575%]

scenario:SamplingRuleMatchingBench/benchRegexMatching2

• 🟥 execution_time [+35.430ns; +118.770ns] or [+2.966%; +9.941%]

scenario:SamplingRuleMatchingBench/benchRegexMatching3

• 🟥 execution_time [+79.633ns; +129.967ns] or [+6.789%; +11.081%]

scenario:SamplingRuleMatchingBench/benchRegexMatching4

• 🟥 execution_time [+59.529ns; +140.871ns] or [+5.064%; +11.983%]

scenario:SpanBench/benchOpenTelemetryAPI

• 🟥 mem_peak [+1.435MB; +1.463MB] or [+3.451%; +3.519%]

scenario:TraceSerializationBench/benchSerializeTrace

• 🟩 execution_time [-39.830µs; -27.470µs] or [-8.809%; -6.076%]

[codecov-commenter]

Codecov Report

❌ Patch coverage is 69.36068% with 254 lines in your changes missing coverage. Please review.
✅ Project coverage is 61.64%. Comparing base (4485a51) to head (2d9bc56).
⚠️ Report is 1 commits behind head on master.

Files with missing lines	Patch %	Lines
appsec/src/extension/json_truncated_parser.cpp	73.72%	47 Missing and 15 partials ⚠️
appsec/src/extension/request_lifecycle.c	12.28%	49 Missing and 1 partial ⚠️
appsec/src/extension/ddappsec.c	52.05%	23 Missing and 12 partials ⚠️
appsec/src/helper/subscriber/waf.cpp	76.92%	20 Missing and 7 partials ⚠️
appsec/src/helper/parameter.cpp	73.73%	18 Missing and 8 partials ⚠️
appsec/src/helper/parameter_view.hpp	76.19%	8 Missing and 7 partials ⚠️
appsec/src/extension/curl.c	7.14%	13 Missing ⚠️
appsec/src/helper/json_helper.cpp	68.75%	6 Missing and 4 partials ⚠️
appsec/src/helper/parameter_base.cpp	63.63%	5 Missing and 3 partials ⚠️
appsec/src/helper/parameter_base.hpp	91.66%	1 Missing and 3 partials ⚠️
... and 3 more

❌ Your patch status has failed because the patch coverage (69.36%) is below the target coverage (90.00%). You can increase the patch coverage or adjust the target coverage.

Additional details and impacted files

@@            Coverage Diff             @@
##           master    #3467      +/-   ##
==========================================
- Coverage   61.88%   61.64%   -0.25%     
==========================================
  Files         142      144       +2     
  Lines       12904    13430     +526     
  Branches     1689     1774      +85     
==========================================
+ Hits         7986     8279     +293     
- Misses       4159     4351     +192     
- Partials      759      800      +41     

Files with missing lines	Coverage Δ
appsec/src/extension/commands/request_exec.c	100.00% <100.00%> (ø)
appsec/src/extension/configuration.h	100.00% <ø> (ø)
appsec/src/extension/php_compat.h	100.00% <ø> (ø)
appsec/src/extension/request_abort.c	73.86% <100.00%> (ø)
appsec/src/extension/user_tracking.c	74.31% <100.00%> (+0.08%)	⬆️
appsec/src/helper/client.cpp	75.98% <100.00%> (ø)
appsec/src/helper/client.hpp	94.11% <ø> (ø)
appsec/src/helper/engine.cpp	91.73% <100.00%> (ø)
appsec/src/helper/engine.hpp	100.00% <ø> (ø)
appsec/src/helper/json_helper.hpp	50.00% <ø> (ø)
... and 16 more

... and 3 files with indirect coverage changes

---

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4485a51...2d9bc56. Read the comment docs.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
• 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

[pr-commenter]

Benchmarks [ appsec ]

Benchmark execution time: 2025-11-21 12:37:20

Comparing candidate commit 2d9bc56 in PR branch glopes/appsec-curl with baseline commit 4485a51 in branch master.

Found 0 performance improvements and 7 performance regressions! Performance is the same for 5 metrics, 0 unstable metrics.

scenario:LaravelBench/benchLaravelBaseline-appsec

• 🟥 mem_peak [+544.720KB; +544.720KB] or [+10.675%; +10.675%]

scenario:LaravelBench/benchLaravelOverhead-appsec

• 🟥 execution_time [+311.214µs; +555.606µs] or [+2.131%; +3.805%]
• 🟥 mem_peak [+544.720KB; +544.720KB] or [+10.675%; +10.675%]

scenario:SymfonyBench/benchSymfonyBaseline-appsec

• 🟥 mem_peak [+544.720KB; +544.720KB] or [+10.675%; +10.675%]

scenario:SymfonyBench/benchSymfonyOverhead-appsec

• 🟥 execution_time [+714.911µs; +873.449µs] or [+6.109%; +7.463%]
• 🟥 mem_peak [+544.720KB; +544.720KB] or [+10.675%; +10.675%]

scenario:WordPressBench/benchWordPressOverhead-appsec

• 🟥 execution_time [+5.574ms; +5.928ms] or [+13.313%; +14.157%]