Skip to content

Conversation

@realFlowControl
Copy link
Member

Description

When converting the environment name to an INI name we asserted on the wrong length, using the ZAI_CONFIG_ENTRIES_COUNT_MAX (300) instead of the ZAI_CONFIG_NAME_BUFSIZ (60). So in theory we could have used ENV names for config options that result in INI names longer then the fixed 60 bytes buffer.

Reviewer checklist

  • Test coverage seems ok.
  • Appropriate labels assigned.

@github-actions github-actions bot added profiling Relates to the Continuous Profiler tracing labels Nov 28, 2025
@realFlowControl realFlowControl marked this pull request as ready for review November 28, 2025 12:41
@realFlowControl realFlowControl requested a review from a team as a code owner November 28, 2025 12:42
@codecov-commenter
Copy link

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 61.78%. Comparing base (c4ac6c5) to head (fe8ec9f).

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #3508      +/-   ##
==========================================
+ Coverage   61.71%   61.78%   +0.07%     
==========================================
  Files         142      142              
  Lines       12923    12923              
  Branches     1695     1695              
==========================================
+ Hits         7975     7985      +10     
+ Misses       4193     4186       -7     
+ Partials      755      752       -3     

see 3 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c4ac6c5...fe8ec9f. Read the comment docs.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@realFlowControl realFlowControl changed the title fix(prpf): fixed asserting length of INI vs ENV fix(prof): fixed asserting length of INI vs ENV Nov 28, 2025
@pr-commenter
Copy link

pr-commenter bot commented Nov 28, 2025

Benchmarks [ profiler ]

Benchmark execution time: 2025-11-28 12:51:00

Comparing candidate commit fe8ec9f in PR branch florian/fix-config-assertion with baseline commit c4ac6c5 in branch master.

Found 0 performance improvements and 0 performance regressions! Performance is the same for 29 metrics, 7 unstable metrics.

@realFlowControl realFlowControl changed the title fix(prof): fixed asserting length of INI vs ENV fix(prof): fixed asserting length of INI Nov 28, 2025
Copy link
Collaborator

@morrisonlevi morrisonlevi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Test failures look unrelated. Code change looks correct.

@realFlowControl realFlowControl merged commit 437fc46 into master Dec 1, 2025
1992 of 2009 checks passed
@realFlowControl realFlowControl deleted the florian/fix-config-assertion branch December 1, 2025 17:14
@github-actions github-actions bot added this to the 1.15.0 milestone Dec 1, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

profiling Relates to the Continuous Profiler tracing

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants