Skip to content

Commit 718c71b

Browse files
authored
Merge pull request #45 from DataFlowAnalysis/empty-node-fix
Fix deletion of temporary empty-nodes
2 parents 7da81a2 + 426f578 commit 718c71b

File tree

2 files changed

+1
-19
lines changed

2 files changed

+1
-19
lines changed

src/features/serialize/defaultDiagram.json

Lines changed: 0 additions & 18 deletions
Original file line numberDiff line numberDiff line change
@@ -163,24 +163,6 @@
163163
"type": "node:storage",
164164
"children": []
165165
},
166-
{
167-
"position": {
168-
"x": 420.76127480457006,
169-
"y": 89.13650030066145
170-
},
171-
"size": {
172-
"width": -1,
173-
"height": -1
174-
},
175-
"strokeWidth": 0,
176-
"selected": false,
177-
"hoverFeedback": false,
178-
"opacity": 1,
179-
"features": {},
180-
"id": "xccftn",
181-
"type": "empty-node",
182-
"children": []
183-
},
184166
{
185167
"position": {
186168
"x": 249,

src/features/toolPalette/edgeCreationTool.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -36,7 +36,7 @@ export class EdgeCreationTool extends CreationTool<SEdge, SEdgeImpl> {
3636
if (this.edgeTargetElement) {
3737
// Pseudo edge target element must always be removed
3838
// regardless of whether the edge creation was successful or cancelled
39-
this.element?.root.remove(this.edgeTargetElement);
39+
this.edgeTargetElement.parent?.remove(this.edgeTargetElement);
4040
this.edgeTargetElement = undefined;
4141
}
4242

0 commit comments

Comments
 (0)