fix: chat topic cannot be generated (#35)

Author: DearVa

src/Everywhere.Abstractions/Extensions/EnumerableExtension.cs

@@ -250,10 +250,26 @@ public static IReadOnlyList<T> ToReadOnlyList<T>(this IEnumerable<T> source)
 
     public static void RemoveRange<T>(this IList<T> list, int index, int count)
     {
-        // 从后往前删除，避免频繁移动元素
+        // Delete from back to front to avoid frequent element shifting
         for (var i = index + count - 1; i >= index; i--)
         {
             list.RemoveAt(i);
         }
     }
+
+    /// <summary>
+    /// Throws if the cancellation token is cancelled during enumeration
+    /// </summary>
+    /// <param name="source"></param>
+    /// <param name="cancellationToken"></param>
+    /// <typeparam name="T"></typeparam>
+    /// <returns></returns>
+    public static IEnumerable<T> WithCancellation<T>(this IEnumerable<T> source, CancellationToken cancellationToken)
+    {
+        foreach (var item in source)
+        {
+            cancellationToken.ThrowIfCancellationRequested();
+            yield return item;
+        }
+    }
 }

src/Everywhere.Abstractions/Utilities/EncodingDetector.cs

@@ -32,8 +32,9 @@ static EncodingDetector()
     /// </summary>
     /// <param name="stream">The stream to analyze. Must be readable and seekable.</param>
     /// <param name="bufferSize">The number of bytes to read for detection. Default is 4096.</param>
+    /// <param name="cancellationToken"></param>
     /// <returns>The detected Encoding, or null if it's binary or undetermined.</returns>
-    public static async Task<Encoding?> DetectEncodingAsync(Stream stream, int bufferSize = 4096)
+    public static async Task<Encoding?> DetectEncodingAsync(Stream stream, int bufferSize = 4096, CancellationToken cancellationToken = default)
     {
         if (!stream.CanRead) throw new ArgumentException("Stream must be readable.", nameof(stream));
         if (!stream.CanSeek) throw new ArgumentException("Stream must be seekable.", nameof(stream));
@@ -45,7 +46,7 @@ static EncodingDetector()
 
         try
         {
-            var bytesRead = await stream.ReadAsync(buffer.AsMemory(0, bufferSize));
+            var bytesRead = await stream.ReadAsync(buffer.AsMemory(0, bufferSize), cancellationToken);
 
             if (bytesRead == 0)
             {

src/Everywhere/AI/OpenAIKernelMixin.cs

@@ -38,22 +38,13 @@ public OpenAIKernelMixin(CustomAssistant customAssistant) : base(customAssistant
         ).AsChatCompletionService();
     }
 
-    public override PromptExecutionSettings? GetPromptExecutionSettings(FunctionChoiceBehavior? functionChoiceBehavior = null)
+    public override PromptExecutionSettings GetPromptExecutionSettings(FunctionChoiceBehavior? functionChoiceBehavior = null)
     {
         double? temperature = _customAssistant.Temperature.IsCustomValueSet ? _customAssistant.Temperature.ActualValue : null;
         double? topP = _customAssistant.TopP.IsCustomValueSet ? _customAssistant.TopP.ActualValue : null;
         double? presencePenalty = _customAssistant.PresencePenalty.IsCustomValueSet ? _customAssistant.PresencePenalty.ActualValue : null;
         double? frequencyPenalty = _customAssistant.FrequencyPenalty.IsCustomValueSet ? _customAssistant.FrequencyPenalty.ActualValue : null;
 
-        if (temperature is null &&
-            topP is null &&
-            presencePenalty is null &&
-            frequencyPenalty is null &&
-            functionChoiceBehavior is null)
-        {
-            return null;
-        }
-
         return new OpenAIPromptExecutionSettings
         {
             Temperature = temperature,
@@ -103,12 +94,13 @@ private sealed class OptimizedOpenAIApiClient(IChatClient client, OpenAIKernelMi
         private static PropertyInfo? _choiceDeltaProperty;
         private static PropertyInfo? _deltaRawDataProperty;
 
-        public Task<ChatResponse> GetResponseAsync(
+        public async Task<ChatResponse> GetResponseAsync(
             IEnumerable<ChatMessage> messages,
             ChatOptions? options = null,
             CancellationToken cancellationToken = default)
         {
-            return client.GetResponseAsync(messages, options, cancellationToken);
+            var res = await client.GetResponseAsync(messages, options, cancellationToken);
+            return res;
         }
 
         public async IAsyncEnumerable<ChatResponseUpdate> GetStreamingResponseAsync(

src/Everywhere/AI/Prompts.cs

@@ -46,9 +46,13 @@ 2. Guess my intentions
         """;
 
     // from: https://github.com/lobehub/lobe-chat/blob/main/src/chains/summaryTitle.ts#L4
-    public const string TitleGeneratorPrompt =
+    public const string TitleGeneratorSystemPrompt = "You are a conversation assistant named Everywhere.";
+
+    public const string TitleGeneratorUserPrompt =
         """
-        You are a conversation assistant named Everywhere. You need to summarize the user's conversation into a topic of 10 words or fewer.
+        Generate a concise and descriptive title for the following conversation.
+        The title should accurately reflect the main topic or purpose of the conversation in a few words.
+        Avoid using generic titles like "Chat" or "Conversation".
         
         User:
         ```markdown

src/Everywhere/Chat/ChatService.cs

@@ -980,8 +980,11 @@ private async Task GenerateTitleAsync(
             {
                 new ChatMessageContent(
                     AuthorRole.System,
+                    Prompts.TitleGeneratorSystemPrompt),
+                new ChatMessageContent(
+                    AuthorRole.User,
                     Prompts.RenderPrompt(
-                        Prompts.TitleGeneratorPrompt,
+                        Prompts.TitleGeneratorUserPrompt,
                         new Dictionary<string, Func<string>>
                         {
                             { "UserMessage", () => userMessage.SafeSubstring(0, 2048) },

src/Everywhere/Chat/Plugins/Impl/FileSystemPlugin.cs

@@ -65,15 +65,18 @@ public FileSystemPlugin(ILogger<FileSystemPlugin> logger) : base("file_system")
 
     [KernelFunction("search_files")]
     [Description(
-        "Search for files and directories in a specified path matching the given search pattern. This tool may slow; avoid using it to enumerate large numbers of files.")]
+        "Search for files and directories in a specified path matching the given search pattern. " +
+        "This tool may slow; avoid using it to enumerate large numbers of files. " +
+        "DO NOT specify the value of `orderBy` when dealing with a large number of files.")]
     [DynamicResourceKey(LocaleKey.NativeChatPlugin_FileSystem_SearchFiles_Header)]
     [FriendlyFunctionCallContentRenderer(typeof(FileRenderer))]
     private string SearchFiles(
         string path,
         [Description("Regex search pattern to match file and directory names.")] string filePattern = ".*",
         int skip = 0,
         [Description("Maximum number of results to return. Max is 1000.")] int maxCount = 100,
-        FilesOrderBy orderBy = FilesOrderBy.Default)
+        FilesOrderBy orderBy = FilesOrderBy.Default,
+        CancellationToken cancellationToken = default)
     {
         if (skip < 0) skip = 0;
         if (maxCount < 0) maxCount = 0;
@@ -90,6 +93,7 @@ private string SearchFiles(
         var regex = new Regex(filePattern, RegexOptions.IgnoreCase | RegexOptions.Compiled, RegexTimeout);
         ExpandFullPath(ref path);
         var query = new RegexFileSystemInfoEnumerable(EnsureDirectoryInfo(path).FullName, regex, true)
+            .WithCancellation(cancellationToken)
             .OfType<FileSystemInfo>()
             .Select(i => new FileRecord(
                 i.Name,
@@ -168,7 +172,9 @@ private async Task<string> SearchFileContentAsync(
         var filesToSearch = fileSystemInfo switch
         {
             FileInfo fileInfo when fileRegex.IsMatch(fileInfo.Name) => [fileInfo],
-            DirectoryInfo directoryInfo => new RegexFileSystemInfoEnumerable(directoryInfo.FullName, fileRegex, true).OfType<FileInfo>(),
+            DirectoryInfo directoryInfo => new RegexFileSystemInfoEnumerable(directoryInfo.FullName, fileRegex, true)
+                .WithCancellation(cancellationToken)
+                .OfType<FileInfo>(),
             _ => []
         };
 
@@ -180,7 +186,7 @@ FileInfo fileInfo when fileRegex.IsMatch(fileInfo.Name) => [fileInfo],
             if (file.Length > maxSearchFileSize) continue;
 
             await using var stream = new FileStream(file.FullName, FileMode.Open, FileAccess.Read, FileShare.Read);
-            if (await EncodingDetector.DetectEncodingAsync(stream) is null)
+            if (await EncodingDetector.DetectEncodingAsync(stream, cancellationToken: cancellationToken) is null)
             {
                 continue;
             }
@@ -248,7 +254,7 @@ private async Task<string> ReadFileAsync(
         }
 
         var stringBuilder = new StringBuilder();
-        if (await EncodingDetector.DetectEncodingAsync(stream) is not { } encoding)
+        if (await EncodingDetector.DetectEncodingAsync(stream, cancellationToken: cancellationToken) is not { } encoding)
         {
             stream.Seek(startBytes, SeekOrigin.Begin);
 
@@ -386,7 +392,9 @@ private async Task<string> DeleteFilesAsync(
             case DirectoryInfo directoryInfo:
             {
                 var regex = new Regex(filePattern, RegexOptions.IgnoreCase | RegexOptions.Compiled, RegexTimeout);
-                infosToDelete = new RegexFileSystemInfoEnumerable(directoryInfo.FullName, regex, true).OfType<FileSystemInfo>();
+                infosToDelete = new RegexFileSystemInfoEnumerable(directoryInfo.FullName, regex, true)
+                    .WithCancellation(cancellationToken)
+                    .OfType<FileSystemInfo>();
                 break;
             }
             default:
@@ -511,7 +519,7 @@ private async Task<string> ReplaceFileContentAsync(
         }
 
         await using var stream = new FileStream(path, FileMode.Open, FileAccess.ReadWrite, FileShare.None);
-        if (await EncodingDetector.DetectEncodingAsync(stream) is not { } encoding)
+        if (await EncodingDetector.DetectEncodingAsync(stream, cancellationToken: cancellationToken) is not { } encoding)
         {
             throw new InvalidOperationException("Cannot replace content in a binary file.");
         }