Diagram: move files to ts (ui.diagram.ts) #31524
Open
+2,960
−2,235
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pharret31
force-pushed
the
25_2_2606-diagram-move-files-to-ts_part1
branch
2 times, most recently
from
c441279 to
042dd6c
Compare
There was a problem hiding this comment.
Pull Request Overview
This PR migrates the Diagram component from JavaScript to TypeScript by:
- Moving the implementation from
packages/devextreme/js/ui/diagram/ui.diagram.jstopackages/devextreme/js/__internal/ui/diagram/ui.diagram.ts - Converting ~2240 lines of JavaScript code to TypeScript with proper type annotations
- Updating the public API file to re-export from the new TypeScript location
- Adding previously hidden widget options (
accessKey,activeStateEnabled,focusStateEnabled,hint,hoverStateEnabled,tabIndex) to Angular and Vue wrappers
Reviewed Changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 8 comments.
| File | Description |
|---|---|
| packages/devextreme/js/ui/diagram/ui.diagram.js | Simplified to re-export from new TypeScript implementation |
| packages/devextreme/js/__internal/ui/diagram/ui.diagram.ts | New TypeScript implementation with type annotations, interfaces, and modernized syntax |
| packages/devextreme-vue/src/diagram.ts | Added 6 previously hidden widget options with proper types and update emitters |
| packages/devextreme-angular/src/ui/diagram/index.ts | Added 6 previously hidden widget options with Input/Output decorators |
pharret31
force-pushed
the
25_2_2606-diagram-move-files-to-ts_part1
branch
2 times, most recently
from
d61d3e6 to
306607e
Compare
EugeniyKiyashko
approved these changes
Oct 30, 2025
pharret31
force-pushed
the
25_2_2606-diagram-move-files-to-ts_part1
branch
from
306607e to
2d0c2fa
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.