Ensure that RefCountersImpl is deleted in the same module where it was created (fix #704)

Author: TheMostDiligent

Common/CMakeLists.txt

@@ -63,6 +63,7 @@ set(SOURCE
     src/GeometryPrimitives.cpp
     src/ImageTools.cpp
     src/MemoryFileStream.cpp
+    src/RefCountedObjectImpl.cpp
     src/Serializer.cpp
     src/SpinLock.cpp
     src/ThreadPool.cpp

Common/interface/RefCountedObjectImpl.hpp

@@ -448,10 +448,9 @@ class RefCountersImpl final : public IReferenceCounters
         }
     }
 
-    void SelfDestroy()
-    {
-        delete this;
-    }
+    static RefCountersImpl* MakeNew();
+
+    void SelfDestroy();
 
     ~RefCountersImpl()
     {
@@ -654,7 +653,7 @@ class MakeNewRCObj
         {
             // Constructor of RefCountersImpl class is private and only accessible
             // by methods of MakeNewRCObj
-            pNewRefCounters = new RefCountersImpl{};
+            pNewRefCounters = RefCountersImpl::MakeNew();
             pRefCounters    = pNewRefCounters;
         }
         ObjectType* pObj = nullptr;

Common/src/RefCountedObjectImpl.cpp

@@ -0,0 +1,44 @@
+/*
+ *  Copyright 2025 Diligent Graphics LLC
+ *
+ *  Licensed under the Apache License, Version 2.0 (the "License");
+ *  you may not use this file except in compliance with the License.
+ *  You may obtain a copy of the License at
+ *
+ *      http://www.apache.org/licenses/LICENSE-2.0
+ *
+ *  Unless required by applicable law or agreed to in writing, software
+ *  distributed under the License is distributed on an "AS IS" BASIS,
+ *  WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ *  See the License for the specific language governing permissions and
+ *  limitations under the License.
+ *
+ *  In no event and under no legal theory, whether in tort (including negligence),
+ *  contract, or otherwise, unless required by applicable law (such as deliberate
+ *  and grossly negligent acts) or agreed to in writing, shall any Contributor be
+ *  liable for any damages, including any direct, indirect, special, incidental,
+ *  or consequential damages of any character arising as a result of this License or
+ *  out of the use or inability to use the software (including but not limited to damages
+ *  for loss of goodwill, work stoppage, computer failure or malfunction, or any and
+ *  all other commercial damages or losses), even if such Contributor has been advised
+ *  of the possibility of such damages.
+ */
+
+#include "RefCountedObjectImpl.hpp"
+
+namespace Diligent
+{
+
+// Define new and delete in the .cpp file to ensure that they are called from the same module
+// (https://github.com/DiligentGraphics/DiligentCore/issues/704)
+RefCountersImpl* RefCountersImpl::MakeNew()
+{
+    return new RefCountersImpl{};
+}
+
+void RefCountersImpl::SelfDestroy()
+{
+    delete this;
+}
+
+} // namespace Diligent