RelationalQueryableExtensions.ExecuteDeleteAsync method not found

[rofr]

Which version of Duende IdentityServer are you using?
7.1.0

Which version of .NET are you using?
8.0

Describe the bug
Token cleanup fails with an exception, probably due to some incompatible package references.

Exception removing expired grants: Method not found: 'System.Threading.Tasks.Task1<Int32> Microsoft.EntityFrameworkCore.RelationalQueryableExtensions.ExecuteDeleteAsync(System.Linq.IQueryable1<!!0>, System.Threading.CancellationToken)'.

Seems like the method is no longer present in version 9.0x of the EF Core libraries:
https://learn.microsoft.com/en-us/dotnet/api/microsoft.entityframeworkcore.relationalqueryableextensions.executedeleteasync?view=efcore-8.0&viewFallbackFrom=efcore-9.0

    <ItemGroup>
        <PackageReference Include="Duende.IdentityServer" Version="7.1.0" />
        <PackageReference Include="Duende.IdentityServer.AspNetIdentity" Version="7.1.0" />
        <PackageReference Include="Duende.IdentityServer.EntityFramework" Version="7.1.0" />
        <PackageReference Include="Duende.IdentityServer.EntityFramework.Storage" Version="7.1.0" />
        <PackageReference Include="Fig" Version="2.0.31" />
        <PackageReference Include="Fig.AppSettingsJson" Version="2.0.31" />
        <PackageReference Include="Microsoft.AspNet.WebApi.Client" Version="6.0.0" />
        <PackageReference Include="Microsoft.AspNetCore.DataProtection.EntityFrameworkCore" Version="6.0.9" />
        <PackageReference Include="Microsoft.EntityFrameworkCore.Design" PrivateAssets="All" Version="9.0.1" />
        <PackageReference Include="Microsoft.AspNetCore.Mvc.Razor.RuntimeCompilation" Version="6.0.9" />
        <PackageReference Include="Microsoft.EntityFrameworkCore.Relational" Version="9.0.1" />
        <PackageReference Include="Microsoft.EntityFrameworkCore.SqlServer" Version="9.0.1" />
        <PackageReference Include="Microsoft.EntityFrameworkCore.Tools" Version="9.0.1">
          <PrivateAssets>all</PrivateAssets>
          <IncludeAssets>runtime; build; native; contentfiles; analyzers; buildtransitive</IncludeAssets>
        </PackageReference>
        <PackageReference Include="Otp.NET" Version="1.4.0" />
        <PackageReference Include="Seq.Extensions.Logging" Version="8.0.0" />

        <PackageReference Include="Serilog.AspNetCore" Version="9.0.0" />

        <PackageReference Include="Serilog.Sinks.Seq" Version="6.0.0" />
    </ItemGroup>

[rofr]

I found the method in a different namespace in 9.0.1:

Microsoft.EntityFrameworkCore.EntityFrameworkQueryableExtensions.ExecuteDeleteAsync()

[maartenba]

(note: we're moving this issue to our new community discussions)

[maets]

Hello! Just a +1 of having the same issue here.

I feel it's a bit odd that the .NET 8 target of https://www.nuget.org/packages/Duende.IdentityServer.EntityFramework.Storage/ is referencing Microsoft.EntityFrameworkCore 8.0.x when Microsoft.EntityFrameworkCore 9.0.x targets .NET 8 (see for example https://www.nuget.org/packages/Microsoft.EntityFrameworkCore.Relational/9.0.3).

I will try to downgrade but it feels like a step in the wrong direction :(

[maartenba]

Let me pick this up with our engineering team. Would it be an option to target net9 in your project so NuGet resolves the IdentityServer net9 assembly as well?

[maets]

Let me pick this up with our engineering team. Would it be an option to target net9 in your project so NuGet resolves the IdentityServer net9 assembly as well?

Possibly yes, but we just got to net8 so we want to give it some time to get mileage in production first.

But we actually opted for a solution where we turned off TokenCleanup - since our regression tests did not pickup any other problems with using EFCore 9 together with Duende (7.2.0) on .NET8.

[maartenba]

That seems like a proper solution. Unfortunately there is a change between EF Core 8.0 and 9.0 that is not breaking at the code level, but does cause a binary breaking change (dotnet/efcore#35105).

Working around this would not be trivial (we tried a few approaches all with different drawbacks). We'd recommend right now to use IdentityServer with EF Core 8 on net8, and IdentityServer with EF Core 9 on net9 (or as you did, implement another solution).

We'll likely change the dependency definition in a future IdentityServer release.

[FDonald]

Hi all, Token cleanup is still failing in 7.3.2 (latest) version.
What is the future release that solve this problem? Or i have to use older EF version to fix this fail?
Thank you for your help.

[maartenba]

Still the same guidance as before: https://github.com/orgs/DuendeSoftware/discussions/24#discussioncomment-12853349 (use ef8 on net8, ef9 on net9)

[FDonald]

Thank you @maartenba, however, dependency tree is confusing:

Duende.IdentityServer.EntityFramework.Storage:
Net 8.0: Microsoft.EntityFrameworkCore.Relational (>= 8.0.11)
and
Net 9.0: Microsoft.EntityFrameworkCore.Relational (>= 9.0.3)

So, it seem that version 9.0.2 is still compatible...

[maartenba]

We're considering bumping to require EF9 on .NET8 as well for a future release, and compile against EF9 so this binary incompatibility is not an issue anymore.