Allow separate registration of BaseServices and DynamicFrontends - V4 incompatibility with Finbuckle.MultiTenant per tenant authentication because of multiple IAuthenticationSchemeProvider injection
#288
Replies: 1 comment 1 reply
-
|
@LionelVallet seeing the issue is closed now, what was the root cause/resolution? |
Beta Was this translation helpful? Give feedback.
1 reply
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
-
It's primarily a Finbuckle issue, but these two libraries are often used together, so I want to highlight a compatibility problem.
The multitenancy framework decorates IAuthenticationSchemeProvider and currently supports only a single provider. However, with the dynamic frontends feature, a second provider is introduced, creating an incompatibility. As a result, Finbuckle's decorator throws an exception:
Finbuckle/Finbuckle.MultiTenant#989
Could you consider decoupling DynamicFrontends from BffBaseServices so that we can add one without the other? Currently, everything is done by
AddBff(), and the methodsAddBffBaseServices()andAddDynamicFrontends()are internal.This could limit the impact for people who do not need dynamic frontends while waiting for a fix. And even in the long term, it avoids configuring unused services.
Beta Was this translation helpful? Give feedback.
All reactions