Skip to content

Fix issue 2786 #2807

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jajhall merged 5 commits into from
Feb 5, 2026
Merged

Fix issue 2786 #2807

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
e38d6bf
Count bounds
fwesselm Feb 2, 2026
9edefff
Merge branch 'latest' of https://github.com/ERGO-Code/HiGHS into High…
fwesselm Feb 3, 2026
c15dbd0
Simplify
fwesselm Feb 4, 2026
1eeb37e
Merge branch 'latest' of https://github.com/ERGO-Code/HiGHS into High…
fwesselm Feb 4, 2026
946a7bb
Simplify a little more
fwesselm Feb 4, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
100 changes: 37 additions & 63 deletions highs/mip/HighsDomain.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1088,44 +1088,18 @@ void HighsDomain::ObjectivePropagation::propagate() {
HighsInt numCol = objNonzeros.size();
for (HighsInt i = objFunc->getNumBinariesInObjective(); i < numCol; ++i) {
HighsInt col = objNonzeros[i];
if (cost[col] > 0) {
if (domain->col_lower_[col] > -kHighsInf) continue;

HighsCDouble boundVal = capacity / cost[col];
if (std::fabs(double(boundVal) * kHighsTiny) > domain->feastol())
continue;

bool accept;
double bound = domain->adjustedUb(col, boundVal, accept);
if (accept) {
domain->changeBound(HighsBoundType::kUpper, col, bound,
Reason::objective());
if (domain->infeasible_) break;
}

break;
} else {
if (domain->col_upper_[col] < kHighsInf) continue;

HighsCDouble boundVal = capacity / cost[col];
if (std::fabs(double(boundVal) * kHighsTiny) > domain->feastol())
continue;

bool accept;
double bound = domain->adjustedLb(col, boundVal, accept);
if (accept) {
domain->changeBound(HighsBoundType::kLower, col, bound,
Reason::objective());
if (domain->infeasible_) break;
}

break;
}
if ((cost[col] > 0 && domain->col_lower_[col] != -kHighsInf) ||
(cost[col] < 0 && domain->col_upper_[col] != kHighsInf))
continue;
domain->checkChangeBound(
cost[col] > 0 ? HighsBoundType::kUpper : HighsBoundType::kLower, col,
capacity / cost[col], Reason::objective());
break;
}
} else {
HighsInt numPartitions = objFunc->getNumCliquePartitions();
double currLb = double(objectiveLower);
while (true) {
HighsInt numBoundChanges = 0;
for (HighsInt i = 0; i < numPartitions; ++i) {
ObjectiveContributionTree contributionTree(this, i);
HighsInt worst = contributionTree.first();
Expand All @@ -1142,12 +1116,14 @@ void HighsDomain::ObjectivePropagation::propagate() {
HighsInt col = objectiveLowerContributions[worst].col;
if (cost[col] > 0) {
if (domain->col_upper_[col] > 0.0) {
numBoundChanges++;
domain->changeBound(HighsBoundType::kUpper, col, 0.0,
Reason::objective());
if (domain->infeasible_) break;
}
} else {
if (domain->col_lower_[col] < 1.0) {
numBoundChanges++;
domain->changeBound(HighsBoundType::kLower, col, 1.0,
Reason::objective());
if (domain->infeasible_) break;
Expand All @@ -1171,11 +1147,13 @@ void HighsDomain::ObjectivePropagation::propagate() {
HighsInt col = objectiveLowerContributions[best].col;
if (cost[col] > 0) {
assert(domain->col_lower_[col] < 1.0);
numBoundChanges++;
domain->changeBound(HighsBoundType::kLower, col, 1.0,
Reason::objective());
if (domain->infeasible_) break;
} else {
assert(domain->col_upper_[col] > 0.0);
numBoundChanges++;
domain->changeBound(HighsBoundType::kUpper, col, 0.0,
Reason::objective());
if (domain->infeasible_) break;
Expand All @@ -1198,40 +1176,23 @@ void HighsDomain::ObjectivePropagation::propagate() {
HighsInt col = objNonzeros[i];

if (cost[col] > 0) {
bool accept;

HighsCDouble boundVal =
(capacity + domain->col_lower_[col] * cost[col]) / cost[col];
if (std::fabs(double(boundVal) * kHighsTiny) > domain->feastol())
continue;

double bound = domain->adjustedUb(col, boundVal, accept);
if (accept) {
domain->changeBound(HighsBoundType::kUpper, col, bound,
Reason::objective());
if (domain->infeasible_) break;
}
if (domain->checkChangeBound(
HighsBoundType::kUpper, col,
(capacity + domain->col_lower_[col] * cost[col]) / cost[col],
Reason::objective()))
numBoundChanges++;
} else {
bool accept;

HighsCDouble boundVal =
(capacity + domain->col_upper_[col] * cost[col]) / cost[col];
if (std::fabs(double(boundVal) * kHighsTiny) > domain->feastol())
continue;

double bound = domain->adjustedLb(col, boundVal, accept);
if (accept) {
domain->changeBound(HighsBoundType::kLower, col, bound,
Reason::objective());
if (domain->infeasible_) break;
}
if (domain->checkChangeBound(
HighsBoundType::kLower, col,
(capacity + domain->col_upper_[col] * cost[col]) / cost[col],
Reason::objective()))
numBoundChanges++;
}
if (domain->infeasible_) break;
}
if (domain->infeasible_) break;

double newLb = double(objectiveLower);
if (newLb == currLb) break;
currLb = newLb;
if (numBoundChanges == 0) break;
capacity = upperLimit - objectiveLower;
}
}
Expand Down Expand Up @@ -2051,6 +2012,19 @@ void HighsDomain::changeBound(HighsDomainChange boundchg, Reason reason) {
}
}

bool HighsDomain::checkChangeBound(HighsBoundType boundtype, HighsInt col,
HighsCDouble boundval, Reason reason) {
if (std::abs(static_cast<double>(boundval * kHighsTiny)) > feastol())
return false;
bool accept;
double bound = boundtype == HighsBoundType::kLower
? adjustedLb(col, boundval, accept)
: adjustedUb(col, boundval, accept);
if (!accept) return false;
changeBound(boundtype, col, bound, reason);
return true;
}

void HighsDomain::setDomainChangeStack(
const std::vector<HighsDomainChange>& domchgstack) {
infeasible_ = false;
Expand Down
3 changes: 3 additions & 0 deletions highs/mip/HighsDomain.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -486,6 +486,9 @@ class HighsDomain {
changeBound({boundval, col, boundtype}, reason);
}

bool checkChangeBound(HighsBoundType boundtype, HighsInt col,
HighsCDouble boundval, Reason reason);

void fixCol(HighsInt col, double val, Reason reason = Reason::unspecified()) {
if (kAllowDeveloperAssert) {
assert(infeasible_ == 0);
Expand Down
Loading