Intrusive forward list add remove by pointer #1026
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Your unit test
I've fixed it in the pulled code. |
|
Thanks for finding and the correct fix. I can confirm it works now also without the "*". |
|
I've also copied the change to |
|
Actually, as I was editing the intrusive lists, I realised that that there was already an It's about 8 years since I wrote the intrusive lists! |
|
I will add a |
jwellbelove
pushed a commit
that referenced
this pull request
Mar 2, 2025
…-pointer' into development # Conflicts: # include/etl/intrusive_forward_list.h
jwellbelove
pushed a commit
that referenced
this pull request
Mar 2, 2025
* Add intrusive_forward_list::remove() element by pointer * Add test
jwellbelove
pushed a commit
that referenced
this pull request
Mar 28, 2025
* Add intrusive_forward_list::remove() element by pointer * Add test
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Besides remove() by reference, I provide this remove() by pointer (overload).
Scenario is as follows:
Current remove() by reference uses the comparison operator, comparing actually different instances for equality. In my use case, I have objects in the intrusive_forward_list which don't have a comparison operator defined but I have a pointer to them. This way, I can intentionally remove the actual object from the list pointed to by the pointer.