Add uncopyable.h, class uncopyable #985
Conversation
|
I don't see a way to add a unit test for this feature. It's a convenience feature which being applied incorrectly would not compile. |
|
If you prefer a unit test including a dummy use of this class (non-functional feature), I can add it. |
| uncopyable& operator=(uncopyable const&) = delete; | ||
|
|
||
| protected: | ||
| uncopyable() = default; |
There was a problem hiding this comment.
I've see comments online that Scott Meyers also adds the destructor in his 'Effective C++' book.
There was a problem hiding this comment.
I.e. a non-virtual public "=default" destructor?
Is there a reasoning behind it?
There was a problem hiding this comment.
It looks like it is intended to make the destructor protected, rather than default public.
There was a problem hiding this comment.
Added the destructor.
jwellbelove
changed the base branch from
master
to
pull-request/#985-Add-uncopyable.h-class-uncopyable
|
I have sometimes added a commented out unit test that contains 'uncompilable' code, with a surrounding comment that the test should fail to compile if uncommented. |
|
I also sometimes do this for |
|
I just added the destructor as discussed, and unit tests, including disabled code that intentionally wouldn't compile. |
jwellbelove
merged commit 0ecab77
into
ETLCPP:pull-request/#985-Add-uncopyable.h-class-uncopyable
* Add uncopyable.h, class uncopyable * Added destructor and unit tests for etl::uncopyable
2 participants
No description provided.