Merge pull request #306 from EasyPost/stronger_verify_tests

chore: stronger verify tests for addresses

Author: Justintime50

CHANGELOG.md

@@ -1,5 +1,9 @@
 # CHANGELOG
 
+## NEXT RELEASE
+
+- Removes the unusable `carrier` param from the `verify` function on an Address
+
 ## v3.3.0 (2022-07-18)
 
 - Adds ability to generate shipment forms via `GenerateForm` function

EasyPost.Tests/AddressTest.cs

@@ -32,13 +32,43 @@ public async Task TestCreate()
             Assert.AreEqual("388 Townsend St", address.street1);
         }
 
+        [TestMethod]
+        public async Task TestCreateVerify()
+        {
+            _vcr.SetUpTest("create_verify");
+
+            Dictionary<string, object> addressData = Fixture.IncorrectAddressToVerify;
+            addressData.Add("verify", true);
+
+            Address address = await Address.Create(addressData);
+
+            Assert.IsInstanceOfType(address, typeof(Address));
+            Assert.IsTrue(address.id.StartsWith("adr_"));
+            Assert.AreEqual("417 MONTGOMERY ST FL 5", address.street1);
+        }
+
         [TestMethod]
         public async Task TestCreateVerifyStrict()
         {
             _vcr.SetUpTest("create_verify_strict");
 
             Dictionary<string, object> addressData = Fixture.BasicAddress;
-            addressData.Add("verify_strict", new List<bool>
+            addressData.Add("verify_strict", true);
+
+            Address address = await Address.Create(addressData);
+
+            Assert.IsInstanceOfType(address, typeof(Address));
+            Assert.IsTrue(address.id.StartsWith("adr_"));
+            Assert.AreEqual("388 TOWNSEND ST APT 20", address.street1);
+        }
+
+        [TestMethod]
+        public async Task TestCreateVerifyArray()
+        {
+            _vcr.SetUpTest("create_verify_array");
+
+            Dictionary<string, object> addressData = Fixture.IncorrectAddressToVerify;
+            addressData.Add("verify", new List<bool>
             {
                 true
             });
@@ -47,10 +77,9 @@ public async Task TestCreateVerifyStrict()
 
             Assert.IsInstanceOfType(address, typeof(Address));
             Assert.IsTrue(address.id.StartsWith("adr_"));
-            Assert.AreEqual("388 TOWNSEND ST APT 20", address.street1);
+            Assert.AreEqual("417 MONTGOMERY ST FL 5", address.street1);
         }
 
-
         [TestMethod]
         public async Task TestRetrieve()
         {
@@ -87,28 +116,12 @@ public async Task TestAll()
             }
         }
 
-        [TestMethod]
-        public async Task TestCreateVerify()
-        {
-            _vcr.SetUpTest("create_verify");
-
-            Address address = await Address.Create(Fixture.IncorrectAddressToVerify);
-
-            Assert.IsInstanceOfType(address, typeof(Address));
-            Assert.IsTrue(address.id.StartsWith("adr_"));
-            Assert.AreEqual("417 MONTGOMERY ST FL 5", address.street1);
-        }
-
         [TestMethod]
         public async Task TestCreateAndVerify()
         {
             _vcr.SetUpTest("create_and_verify");
 
             Dictionary<string, object> addressData = Fixture.BasicAddress;
-            addressData.Add("verify_strict", new List<bool>
-            {
-                true
-            });
 
             Address address = await Address.CreateAndVerify(addressData);
 
@@ -122,7 +135,6 @@ public async Task TestVerify()
         {
             _vcr.SetUpTest("verify");
 
-
             Address address = await CreateBasicAddress();
 
             await address.Verify();

EasyPost.Tests/Fixture.cs

@@ -79,12 +79,6 @@ public static Dictionary<string, object> IncorrectAddressToVerify
             {
                 return new Dictionary<string, object>
                 {
-                    {
-                        "verify", new List<bool>
-                        {
-                            true
-                        }
-                    },
                     {
                         "street1", "417 montgomery street"
                     },