Add static analysis tool (#290)

nwithan8 · web-flow · commit c78ecc7bdf9a · 2022-07-06T15:26:48.000-06:00
- Add SecurityCodeScan as NuGet dependency (during build, not install)
- Add SecurityCodeScan as CI step
- Makefile command for security scan (must run manually)
- Fix some linting
diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml
@@ -14,6 +14,17 @@ jobs:
       - uses: actions/checkout@v3
       - name: Check dotnet Style
         run: dotnet-format --check --exclude /
+  security:
+    runs-on: windows-2022
+    steps:
+      - name: Install security-code-scan
+        run: dotnet tool install -g security-scan
+      - uses: actions/checkout@v3
+      - name: Run security analysis
+        run: security-scan EasyPost.sln --ignore-msbuild-errors --verbose
+        # "--ignore-msbuild-errors" needed since MSBuild does not like F#: https://github.com/security-code-scan/security-code-scan/issues/235
+        # In the future, we can collect the output logs by enabling Code Scanning and using the pre-built GitHub Action: https://github.com/marketplace/actions/securitycodescan
+        # https://docs.github.com/en/code-security/code-scanning/integrating-with-code-scanning/uploading-a-sarif-file-to-github#uploading-a-code-scanning-analysis-with-github-actions
   NET_Tests:
     # derived from https://dev.to/felipetofoli/github-actions-for-net-full-framework-build-and-test-299h
     runs-on: windows-2022
diff --git a/EasyPost.Tests.FSharp/EasyPost.Tests.FSharp.fsproj b/EasyPost.Tests.FSharp/EasyPost.Tests.FSharp.fsproj
@@ -14,9 +14,13 @@
     </ItemGroup>
 
     <ItemGroup>
-      <PackageReference Include="Microsoft.NET.Test.Sdk" Version="17.1.0" />
-      <PackageReference Include="MSTest.TestAdapter" Version="2.2.8" />
-      <PackageReference Include="MSTest.TestFramework" Version="2.2.8" />
+        <PackageReference Include="Microsoft.NET.Test.Sdk" Version="17.1.0"/>
+        <PackageReference Include="MSTest.TestAdapter" Version="2.2.8"/>
+        <PackageReference Include="MSTest.TestFramework" Version="2.2.8"/>
+        <PackageReference Include="SecurityCodeScan.VS2019" Version="[5.0.0, 6.0.0)">
+            <PrivateAssets>all</PrivateAssets>
+            <IncludeAssets>runtime; build; native; contentfiles; analyzers; buildtransitive</IncludeAssets>
+        </PackageReference>
     </ItemGroup>
 
 </Project>
diff --git a/EasyPost.Tests.VB/EasyPost.Tests.VB.vbproj b/EasyPost.Tests.VB/EasyPost.Tests.VB.vbproj
@@ -10,9 +10,13 @@
     </ItemGroup>
 
     <ItemGroup>
-      <PackageReference Include="Microsoft.NET.Test.Sdk" Version="17.1.0" />
-      <PackageReference Include="MSTest.TestAdapter" Version="2.2.8" />
-      <PackageReference Include="MSTest.TestFramework" Version="2.2.8" />
+      <PackageReference Include="Microsoft.NET.Test.Sdk" Version="17.1.0"/>
+      <PackageReference Include="MSTest.TestAdapter" Version="2.2.8"/>
+      <PackageReference Include="MSTest.TestFramework" Version="2.2.8"/>
+      <PackageReference Include="SecurityCodeScan.VS2019" Version="[5.0.0, 6.0.0)">
+        <PrivateAssets>all</PrivateAssets>
+        <IncludeAssets>runtime; build; native; contentfiles; analyzers; buildtransitive</IncludeAssets>
+      </PackageReference>
     </ItemGroup>
 
 </Project>
diff --git a/EasyPost.Tests/EasyPost.Tests.csproj b/EasyPost.Tests/EasyPost.Tests.csproj
@@ -12,13 +12,17 @@
   </PropertyGroup>
 
   <ItemGroup>
-    <PackageReference Include="EasyVCR" Version="0.3.1" />
-    <PackageReference Include="Microsoft.NET.Test.Sdk" Version="16.5.0" />
-    <PackageReference Include="coverlet.collector" Version="1.2.0" />
-    <PackageReference Include="Newtonsoft.Json" Version="[13.0.1, 14.0.0)" />
-    <PackageReference Include="RestSharp" Version="[107.3.0, 108.0.0)" />
-    <PackageReference Include="MSTest.TestFramework" Version="2.2.8" />
-    <PackageReference Include="MSTest.TestAdapter" Version="2.2.8" />
+    <PackageReference Include="EasyVCR" Version="0.3.1"/>
+    <PackageReference Include="Microsoft.NET.Test.Sdk" Version="16.5.0"/>
+    <PackageReference Include="coverlet.collector" Version="1.2.0"/>
+    <PackageReference Include="Newtonsoft.Json" Version="[13.0.1, 14.0.0)"/>
+    <PackageReference Include="RestSharp" Version="[107.3.0, 108.0.0)"/>
+    <PackageReference Include="MSTest.TestFramework" Version="2.2.8"/>
+    <PackageReference Include="MSTest.TestAdapter" Version="2.2.8"/>
+    <PackageReference Include="SecurityCodeScan.VS2019" Version="[5.0.0, 6.0.0)">
+      <PrivateAssets>all</PrivateAssets>
+      <IncludeAssets>runtime; build; native; contentfiles; analyzers; buildtransitive</IncludeAssets>
+    </PackageReference>
   </ItemGroup>
 
   <ItemGroup>
diff --git a/EasyPost/Base/Address.cs b/EasyPost/Base/Address.cs
@@ -1,5 +1,4 @@
 using System;
-using System.Collections.Generic;
 using Newtonsoft.Json;
 
 namespace EasyPost.Base
diff --git a/EasyPost/EasyPost.csproj b/EasyPost/EasyPost.csproj
@@ -61,6 +61,10 @@
   <ItemGroup>
     <PackageReference Include="Newtonsoft.Json" Version="[13.0.1, 14.0.0)"/>
     <PackageReference Include="RestSharp" Version="[107.3.0, 108.0.0)"/>
+    <PackageReference Include="SecurityCodeScan.VS2019" Version="[5.0.0, 6.0.0)">
+      <PrivateAssets>all</PrivateAssets>
+      <IncludeAssets>runtime; build; native; contentfiles; analyzers; buildtransitive</IncludeAssets>
+    </PackageReference>
   </ItemGroup>
 
 </Project>
diff --git a/EasyPost/Exception.cs b/EasyPost/Exception.cs
@@ -1,7 +1,6 @@
 ﻿using System;
 using System.Collections.Generic;
 using System.Runtime.Serialization;
-using System.Security.Permissions;
 
 namespace EasyPost
 {
@@ -52,14 +51,14 @@ public class PropertyMissing : Exception
     {
         private readonly string _property;
 
-        public PropertyMissing(string property)
+        public override string Message
         {
-            _property = property;
+            get { return $"Missing {_property}"; }
         }
 
-        public override string Message
+        public PropertyMissing(string property)
         {
-            get { return $"Missing {_property}"; }
+            _property = property;
         }
     }
 
diff --git a/EasyPost/Pickup.cs b/EasyPost/Pickup.cs
@@ -1,7 +1,6 @@
 ﻿using System;
 using System.Collections.Generic;
 using System.Threading.Tasks;
-using EasyPost.Utilities;
 using Newtonsoft.Json;
 using RestSharp;
 
diff --git a/EasyPost/Shipment.cs b/EasyPost/Shipment.cs
@@ -1,6 +1,5 @@
 ﻿using System;
 using System.Collections.Generic;
-using System.Linq;
 using System.Threading.Tasks;
 using EasyPost.Utilities;
 using Newtonsoft.Json;
diff --git a/Makefile b/Makefile
@@ -24,6 +24,10 @@ build:
 install-cert:
 	scripts\install_cert.bat ${cert} ${pass}
 
+## install-scanner - Install SecurityCodeScan to your system
+install-scanner:
+	dotnet tool install -g security-scan
+
 ## sign - Sign all generated DLLs and NuGet packages with the provided certificate (Windows only)
 # @parameters:
 # cert= - The certificate to use for signing the built assets.
@@ -56,4 +60,10 @@ test:
 lint-scripts:
 	scripts\lint_scripts.bat
 
-.PHONY: help release build-dev build install-cert sign clean restore lint lint-check test lint-scripts
+## scan - Scan the project for security issues (must run install-scanner first)
+# Makefile cannot access global dotnet tools, so you need to run the below command manually.
+scan:
+	security-scan --verbose --no-banner --ignore-msbuild-errors EasyPost.sln
+	# "--ignore-msbuild-errors" needed since MSBuild does not like F#: https://github.com/security-code-scan/security-code-scan/issues/235
+
+.PHONY: help release build-dev build install-cert sign clean restore lint lint-check test lint-scripts install-scanner scan

Original file line number	Diff line number	Diff line change
`@@ -1,5 +1,4 @@`
`1`	`1`	`using System;`
`2`		`-using System.Collections.Generic;`
`3`	`2`	`using Newtonsoft.Json;`
`4`	`3`
`5`	`4`	`namespace EasyPost.Base`
Original file line number	Diff line number	Diff line change
`@@ -1,7 +1,6 @@`
`1`	`1`	`using System;`
`2`	`2`	`using System.Collections.Generic;`
`3`	`3`	`using System.Runtime.Serialization;`
`4`		`-using System.Security.Permissions;`
`5`	`4`
`6`	`5`	`namespace EasyPost`
`7`	`6`	`{`
`@@ -52,14 +51,14 @@ public class PropertyMissing : Exception`
`52`	`51`	`{`
`53`	`52`	`private readonly string _property;`
`54`	`53`
`55`		`- public PropertyMissing(string property)`
	`54`	`+ public override string Message`
`56`	`55`	`{`
`57`		`- _property = property;`
	`56`	`+ get { return $"Missing {_property}"; }`
`58`	`57`	`}`
`59`	`58`
`60`		`- public override string Message`
	`59`	`+ public PropertyMissing(string property)`
`61`	`60`	`{`
`62`		`- get { return $"Missing {_property}"; }`
	`61`	`+ _property = property;`
`63`	`62`	`}`
`64`	`63`	`}`
`65`	`64`