fix: error type

Author: Justintime50

easypost/services/billing_service.py

@@ -9,7 +9,7 @@
     NO_BILLING_ERROR,
 )
 from easypost.easypost_object import convert_to_easypost_object
-from easypost.errors import PaymentError
+from easypost.errors import InvalidObjectError
 from easypost.models import Billing
 from easypost.requestor import (
     RequestMethod,
@@ -49,7 +49,7 @@ def retrieve_payment_methods(self, **params) -> Dict[str, Any]:
         )
 
         if response.get("id") is None:
-            raise PaymentError(message=NO_BILLING_ERROR)
+            raise InvalidObjectError(message=NO_BILLING_ERROR)
 
         return convert_to_easypost_object(response=response)
 
@@ -71,8 +71,8 @@ def _get_payment_method_info(self, priority: str = "primary") -> List[str]:
             elif payment_method_id.startswith("bank_"):
                 endpoint = "/bank_accounts"
             else:
-                raise PaymentError(message=INVALID_PAYMENT_METHOD_ERROR)
+                raise InvalidObjectError(message=INVALID_PAYMENT_METHOD_ERROR)
         else:
-            raise PaymentError(message=INVALID_PAYMENT_METHOD_ERROR)
+            raise InvalidObjectError(message=INVALID_PAYMENT_METHOD_ERROR)
 
         return [endpoint, payment_method_id]

tests/test_billing.py

@@ -3,7 +3,7 @@
 import pytest
 
 import easypost
-from easypost.errors import PaymentError
+from easypost.errors import InvalidObjectError
 
 
 @patch(
@@ -54,7 +54,7 @@ def test_billing_payment_method_delete_bank_account(mock_request, mock_payment_m
 @patch("easypost.services.billing_service.Requestor.request", return_value={"mock": "response"})
 def test_billing_payment_method_delete_invalid(mock_request, mock_payment_methods, prod_client):
     """Tests we raise an error when we receive an invalid payment method"""
-    with pytest.raises(PaymentError):
+    with pytest.raises(InvalidObjectError):
         _ = prod_client.billing.delete_payment_method(priority="primary")
 
 
@@ -65,7 +65,7 @@ def test_billing_payment_method_delete_invalid(mock_request, mock_payment_method
 @patch("easypost.services.billing_service.Requestor.request", return_value={"mock": "response"})
 def test_billing_payment_method_delete_bad_request(mock_request, mock_payment_methods, prod_client):
     """Tests we raise an error when we cannot retrieve a payment method."""
-    with pytest.raises(PaymentError):
+    with pytest.raises(InvalidObjectError):
         _ = prod_client.billing.delete_payment_method(priority="tertiary")
 
 
@@ -81,7 +81,7 @@ def test_billing_retrieve_payment_methods(mock_request, prod_client):
 @patch("easypost.services.billing_service.Requestor.request", return_value={"mock": "response"})
 def test_billing_retrieve_payment_methods_no_billing_setup(mock_request, prod_client):
     """Tests that we throw an error when we cannot retrieve payment methods due to no billing being setup."""
-    with pytest.raises(PaymentError) as error:
+    with pytest.raises(InvalidObjectError) as error:
         _ = prod_client.billing.retrieve_payment_methods()
 
     mock_request.assert_called_once()