Skip to content

Conversation

@RFCreate
Copy link
Contributor

  • I have read the note above about PRs contributing or fixing extensions
  • I have tried reaching out to the extension maintainers about publishing this extension to Open VSX (if not, please create an issue in the extension's repo using this template).
  • This extension has an OSI-approved OSS license (we don't accept proprietary extensions in this repository)

Description

This PR fixes should fix the outdated extension mads-hartmann.bash-ide-vscode by adding the dependency pnpm that was changed in this commit.

@filiptronicek
Copy link
Contributor

Hey there @RFCreate 👋 and thanks for the contribution! PR looks great, so I'd love to ask you to sign the Eclipse Contributor Agreement, so that we can get it merged.

You should be able to find the link to sign in the PR checks below

@RFCreate
Copy link
Contributor Author

@filiptronicek is there a problem if i remove the my intermediate commit for this to pass?

@filiptronicek
Copy link
Contributor

@RFCreate I am not sure if I follow exactly? Feel free to structure your git history on the PR however you'd like - the missing bit from my side is the Eclipse Contributor Agreement we need signed to be able to accept your contribution. This should be possible to do from this link:
https://api.eclipse.org/git/eca/status/gh/EclipseFdn/publish-extensions/814

@RFCreate
Copy link
Contributor Author

I thought that would work 😞

@RFCreate
Copy link
Contributor Author

Okay that work, didn't know I could do that, I will revert back if you request 😅

Copy link
Contributor

@filiptronicek filiptronicek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@RFCreate it indeed looks like you made the CI check happy. LGTM!

@filiptronicek filiptronicek merged commit 58144f2 into EclipseFdn:master Feb 27, 2025
1 of 2 checks passed
@RFCreate
Copy link
Contributor Author

Thanks for this!

@RFCreate RFCreate deleted the bash-ide-vscode branch February 28, 2025 18:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants