Eibon7
diff --git a/‎.claude/skills/gdd/SKILL.md‎
Lines changed: 210 additions & 0 deletions b/‎.claude/skills/gdd/SKILL.md‎
Lines changed: 210 additions & 0 deletions
diff --git a/‎.github/workflows/pre-merge-validation.yml‎
Lines changed: 163 additions & 0 deletions b/‎.github/workflows/pre-merge-validation.yml‎
Lines changed: 163 additions & 0 deletions
@@ -0,0 +1,210 @@
+---
+name: gdd
+description: Load GDD context for an issue (assessment + node resolution + pattern awareness)
+---
+
+# GDD Context Loader
+
+You are the **GDD Context Loader** for the Roastr.ai project. Your mission is to prepare the complete development context for an issue by executing FASE 0 (Assessment) and FASE 1 (GDD Context Loading) from the standard workflow.
+
+## Your Responsibilities
+
+### 1. Fetch Issue Metadata
+
+Execute:
+```bash
+gh issue view {issue_number} --json labels,title,body,number
+```
+
+Parse the response to extract:
+- **Title**: Issue title
+- **Labels**: All labels (especially `area:*`, `priority:*`, `test:*`)
+- **Body**: Full issue description
+- **Acceptance Criteria**: Count AC items (look for numbered lists, checkboxes, or "AC:" sections)
+
+---
+
+### 2. Assessment (FASE 0)
+
+**Decision criteria:**
+
+- **≤2 Acceptance Criteria** → **Inline Assessment**
+  - Execute simple assessment directly
+  - Determine recommendation: CREATE | FIX | ENHANCE | CLOSE
+  - Document inline (no separate file)
+
+- **≥3 Acceptance Criteria OR Priority P0/P1** → **Task Assessor Agent**
+  - Invoke Task tool with subagent_type="Task Assessor"
+  - Agent generates: `docs/assessment/issue-{id}.md`
+  - Wait for agent response with recommendation
+
+---
+
+### 3. Read Known Patterns (MANDATORY)
+
+**Always read before proceeding:**
+```bash
+Read: docs/patterns/coderabbit-lessons.md
+```
+
+**Extract:**
+- Common mistakes for this type of issue
+- Pre-implementation checklist items
+- Security considerations
+- Testing patterns
+
+**Announce:** Key patterns relevant to this issue (max 3 most important)
+
+---
+
+### 4. Map Labels → GDD Nodes
+
+**Execute:**
+```bash
+node scripts/get-label-mapping.js --format=compact
+```
+
+**Mapping logic:**
+
+- **Primary:** Use `area:*` labels
+  - `area:auth` → `auth-system`
+  - `area:billing` → `cost-control`
+  - `area:frontend` → `frontend-layer`
+  - (etc., see full mapping in script output)
+
+- **Fallback:** If no `area:*` label, use keyword detection in title/body
+  - "login", "registro" → `auth-system`
+  - "queue", "worker" → `queue-system`
+  - "shield", "moderation" → `shield-system`
+  - (etc.)
+
+- **Multiple nodes:** If issue affects multiple areas, list all
+
+---
+
+### 5. Resolve GDD Dependencies
+
+**Execute:**
+```bash
+node scripts/resolve-graph.js <node1> <node2> <nodeN>
+```
+
+**This script:**
+- Resolves dependencies between nodes
+- Returns complete list of nodes to load
+- Prevents circular dependencies
+
+**Load ONLY resolved nodes** (NEVER load entire spec.md unless explicitly required)
+
+---
+
+### 6. Load Node Documentation
+
+For each resolved node:
+```bash
+Read: docs/nodes/<node-name>.md
+```
+
+**Extract from each node:**
+- **Purpose**: What this node does
+- **Current Status**: Implementation state
+- **Dependencies**: Other nodes it depends on
+- **Agentes Relevantes**: Which agents work on this node
+- **Test Coverage**: Current coverage percentage
+
+---
+
+### 7. Announce Context Loaded
+
+Generate a structured announcement with this **exact format**:
+
+```markdown
+✅ GDD Context Loaded for Issue #{issue_number}
+
+📋 **Issue**: {title}
+🏷️  **Labels**: {comma-separated labels}
+🎯 **Assessment**: {recommendation} ({inline | Task Assessor invoked})
+
+📦 **GDD Nodes Loaded**: ({count} nodes)
+   1. {node-name} - {brief description} [{status}]
+   2. {node-name} - {brief description} [{status}]
+   ...
+
+⚠️  **Known Patterns** (from coderabbit-lessons.md):
+   • {pattern 1}
+   • {pattern 2}
+   • {pattern 3}
+
+🔧 **Pre-Implementation Checklist**:
+   - [ ] {checklist item from lessons}
+   - [ ] {checklist item from lessons}
+   - [ ] {checklist item from lessons}
+
+📊 **Node Health Summary**:
+   • Average Coverage: {percentage}%
+   • Nodes with Tests: {count}/{total}
+   • Dependencies Resolved: ✅
+
+---
+**Ready for FASE 2: Planning** 📝
+Use loaded context to create `docs/plan/issue-{id}.md`
+```
+
+---
+
+## Error Handling
+
+**If issue not found:**
+- Report error clearly
+- Suggest: `gh issue list --state open` to see available issues
+
+**If no labels:**
+- Use keyword fallback
+- Warn user: "No area labels found, using keyword detection"
+
+**If node resolution fails:**
+- Report which node failed
+- Suggest: Check node name spelling or ask user which area
+
+**If coderabbit-lessons.md missing:**
+- Warn but continue
+- Skip pattern announcement section
+
+---
+
+## Example Invocation
+
+User types: `/gdd 408`
+
+You execute:
+1. `gh issue view 408 --json labels,title,body,number`
+2. Count AC → 5 criteria → Invoke Task Assessor Agent
+3. Read `docs/patterns/coderabbit-lessons.md`
+4. Detect labels: `area:auth`, `priority:P1`
+5. `node scripts/resolve-graph.js auth-system`
+6. Load resolved nodes: `auth-system`, `database-layer`, `api-layer`
+7. Announce context with format above
+
+---
+
+## Success Criteria
+
+✅ Issue metadata fetched successfully
+✅ Assessment completed (inline or via agent)
+✅ Known patterns identified
+✅ GDD nodes resolved and loaded
+✅ Context announcement formatted correctly
+✅ User can proceed to FASE 2 with complete context
+
+---
+
+## Security Notes
+
+- ❌ NEVER expose API keys or credentials
+- ❌ NEVER load entire spec.md (use resolved nodes only)
+- ✅ ALWAYS validate issue number is numeric
+- ✅ ALWAYS handle missing files gracefully
+
+---
+
+**You are now ready to load GDD context. Wait for user to provide issue number.**
@@ -0,0 +1,163 @@
+name: Pre-Merge Completion Validation
+
+on:
+  pull_request:
+    types: [opened, synchronize, reopened, labeled]
+  workflow_dispatch:
+    inputs:
+      pr_number:
+        description: 'PR number to validate'
+        required: true
+        type: number
+
+permissions:
+  contents: read
+  pull-requests: write
+  issues: read
+
+jobs:
+  validate-completion:
+    name: Validate PR Completion
+    runs-on: ubuntu-latest
+    if: |
+      github.event_name == 'workflow_dispatch' ||
+      contains(github.event.pull_request.labels.*.name, 'ready-to-merge') ||
+      contains(github.event.pull_request.labels.*.name, 'validate-completion')
+
+    steps:
+      - name: Checkout code
+        uses: actions/checkout@v4
+        with:
+          fetch-depth: 0
+
+      - name: Setup Node.js
+        uses: actions/setup-node@v4
+        with:
+          node-version: '18'
+          cache: 'npm'
+
+      - name: Install dependencies
+        run: npm ci
+
+      - name: Run test suite with coverage
+        id: tests
+        run: |
+          npm test -- --coverage > test-output.txt 2>&1 || true
+          echo "test_output<<EOF" >> $GITHUB_OUTPUT
+          cat test-output.txt >> $GITHUB_OUTPUT
+          echo "EOF" >> $GITHUB_OUTPUT
+        continue-on-error: true
+        env:
+          NODE_ENV: test
+
+      - name: Setup GitHub CLI
+        run: |
+          type -p gh >/dev/null || {
+            curl -fsSL https://cli.github.com/packages/githubcli-archive-keyring.gpg | sudo dd of=/usr/share/keyrings/githubcli-archive-keyring.gpg
+            echo "deb [arch=$(dpkg --print-architecture) signed-by=/usr/share/keyrings/githubcli-archive-keyring.gpg] https://cli.github.com/packages stable main" | sudo tee /etc/apt/sources.list.d/github-cli.list > /dev/null
+            sudo apt update
+            sudo apt install gh -y
+          }
+
+      - name: Authenticate GitHub CLI
+        run: echo "${{ secrets.GITHUB_TOKEN }}" | gh auth login --with-token
+
+      - name: Install js-yaml (required for validation scripts)
+        run: npm install js-yaml
+
+      - name: Run Completion Validation
+        id: validate
+        env:
+          GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
+          PR_NUMBER: ${{ github.event.pull_request.number || github.event.inputs.pr_number }}
+          COVERAGE_THRESHOLD: 90
+          TEST_OUTPUT_FILE: test-output.txt
+        run: |
+          echo "🛡️ Running Guardian Completion Validation..."
+          node scripts/ci/validate-completion.js --pr=$PR_NUMBER
+        continue-on-error: true
+
+      - name: Check validation result
+        if: steps.validate.outcome == 'failure'
+        run: |
+          echo "❌ PR is not 100% complete"
+          echo "Review the validation output above for specific issues"
+          echo ""
+          echo "Common issues:"
+          echo "  - Acceptance criteria incomplete"
+          echo "  - Test coverage below threshold"
+          echo "  - Tests failing"
+          echo "  - Missing agent receipts"
+          echo "  - Documentation not updated"
+          echo "  - CodeRabbit comments pending"
+          echo ""
+          echo "Fix all issues and re-push to trigger validation again"
+          exit 1
+
+      - name: Post success comment (if complete)
+        if: steps.validate.outcome == 'success'
+        env:
+          GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
+          PR_NUMBER: ${{ github.event.pull_request.number || github.event.inputs.pr_number }}
+        run: |
+          gh pr comment $PR_NUMBER --body "✅ **Guardian Completion Validation: PASSED**
+
+          This PR is 100% complete and ready to merge:
+          - ✅ All acceptance criteria met
+          - ✅ Test coverage ≥90%
+          - ✅ All tests passing
+          - ✅ Agent receipts present
+          - ✅ Documentation updated
+          - ✅ CodeRabbit: 0 comments
+          - ✅ CI/CD: All checks passing
+
+          🎉 User may proceed with merge when ready."
+
+      - name: Post failure comment (if incomplete)
+        if: steps.validate.outcome == 'failure'
+        env:
+          GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
+          PR_NUMBER: ${{ github.event.pull_request.number || github.event.inputs.pr_number }}
+        run: |
+          gh pr comment $PR_NUMBER --body "⚠️ **Guardian Completion Validation: INCOMPLETE**
+
+          This PR is not ready to merge. Review the CI logs for specific issues.
+
+          **Next steps:**
+          1. Review validation output in the CI job logs
+          2. Fix all pending items
+          3. Re-push changes to re-trigger validation
+
+          **Common fixes:**
+          - Complete remaining acceptance criteria
+          - Increase test coverage
+          - Fix failing tests
+          - Generate missing agent receipts
+          - Update GDD nodes and documentation
+          - Resolve CodeRabbit comments
+
+          See \`docs/policies/completion-validation.md\` for full guidelines."
+
+      - name: Upload coverage report
+        if: always()
+        uses: actions/upload-artifact@v4
+        with:
+          name: coverage-report
+          path: coverage/
+          retention-days: 7
+
+  # Require this check to pass before allowing merge
+  completion-required:
+    name: Completion Validation Required
+    runs-on: ubuntu-latest
+    needs: validate-completion
+    if: always()
+    steps:
+      - name: Check completion validation passed
+        run: |
+          if [ "${{ needs.validate-completion.result }}" != "success" ]; then
+            echo "❌ Completion validation did not pass"
+            echo "PR cannot be merged until validation succeeds"
+            exit 1
+          fi
+          echo "✅ Completion validation passed"