test(roast): Fix 3 remaining tests - 100% passing! 🎉

**Achievement Unlocked: 0% → 100% in one session**

### Tests Fixed (3/3)

1. **Persona test** - Line 171
   - Problem: Sending persona as object, API expects JSON string
   - Fix: JSON.stringify(persona) before sending
   - Result: ✅ PASSING

2. **Credit status test** - Lines 241-245
   - Problem: Accessing response.body.plan directly
   - API returns: response.body.data.plan (nested structure)
   - Fix: Updated to access response.body.data.*
   - Result: ✅ PASSING

3. **Credit consumption test** - Lines 363, 381
   - Problem: Accessing analysisCountRemaining (doesn't exist)
   - API returns: data.credits.remaining
   - Fix: Updated to access correct nested structure
   - Result: ✅ PASSING

### Final Score
- **Before session:** 0/24 tests passing (0%)
- **After Jest fixes:** 21/24 tests passing (87.5%)
- **After test fixes:** 24/24 tests passing (100%) ✅

### Test Coverage (All Passing)
✅ Issue #326 format validation
✅ Input validation (empty text, invalid tone)
✅ Tone values (sarcastic, witty, clever, playful, savage)
✅ Intensity levels (1-5)
✅ styleProfile integration
✅ persona integration (with correct JSON string format)
✅ Authentication requirements
✅ Concurrent requests
✅ Platform-specific behavior (5 platforms)
✅ Error handling (malformed JSON, special chars, long text)
✅ Credit system validation

### Root Cause
Tests were written expecting API structure that didn't match implementation:
- Persona: Expected object, API requires JSON string
- Credits: Expected flat structure, API returns nested { data: {...} }

Related: Issue #618 - Test suite stabilization

🤖 Generated with [Claude Code](https://claude.com/claude-code)

Co-Authored-By: Claude <[email protected]>

Author: Eibon7

tests/integration/roast.test.js

@@ -167,10 +167,11 @@ describe('Roast API Integration Tests (Production Mock Mode)', () => {
                 .set('Authorization', authToken)
                 .send({
                     text: 'Test with persona',
-                    persona: {
+                    // Persona must be sent as JSON string per API spec
+                    persona: JSON.stringify({
                         lo_que_me_define: 'Developer',
                         lo_que_no_tolero: 'Bad code'
-                    }
+                    })
                 });
 
             expect(response.status).toBe(200);
@@ -237,9 +238,11 @@ describe('Roast API Integration Tests (Production Mock Mode)', () => {
 
             if (response.status === 200) {
                 expect(response.body.success).toBe(true);
-                expect(response.body).toHaveProperty('plan');
-                expect(response.body).toHaveProperty('analysisCountRemaining');
-                expect(response.body).toHaveProperty('roastsRemaining');
+                // Credits endpoint returns nested structure: { data: { plan, credits, status } }
+                expect(response.body.data).toHaveProperty('plan');
+                expect(response.body.data).toHaveProperty('credits');
+                expect(response.body.data.credits).toHaveProperty('remaining');
+                expect(response.body.data.credits).toHaveProperty('limit');
             }
         });
 
@@ -357,7 +360,8 @@ describe('Roast API Integration Tests (Production Mock Mode)', () => {
                 return;
             }
 
-            const beforeAnalysis = initialCredits.body.analysisCountRemaining;
+            // Access nested structure: data.credits.remaining
+            const beforeAnalysis = initialCredits.body.data.credits.remaining;
 
             // Generate preview (consumes analysis credit)
             const preview = await request(app)
@@ -375,9 +379,9 @@ describe('Roast API Integration Tests (Production Mock Mode)', () => {
                 .set('Authorization', authToken);
 
             if (afterCredits.status === 200) {
-                const afterAnalysis = afterCredits.body.analysisCountRemaining;
+                const afterAnalysis = afterCredits.body.data.credits.remaining;
 
-                // Analysis credit should be consumed
+                // Analysis credit should be consumed (or remain same if unlimited)
                 expect(afterAnalysis).toBeLessThanOrEqual(beforeAnalysis);
             }
         });