Wrong fallback value for persistent url

[dennisvang]

description

According to the docs:

If you don't specify persistentUrl, the clientUrl will be used instead.

However, if we do not specify peristentUrl, the actual fallback value includes the app server port.

For example if we only specify clientUrl: http://localhost, and the app server (server.port) listens on 8080, the resulting persistentUrl value is http://localhost:8080, instead of the expected http://localhost.

As a result, the fdp rdf subject is wrong (note the mismatch between the highlighted strings):

and so are links like the following:

how to reproduce

1. clone the FAIRDataTeam/compose repo
2. cd compose/fdp/ephemeral/v1
3. temporarily add a compose.override.yml file in this dir, with the following content

   services:
     fdp:
       environment:
         INSTANCE_PERSISTENTURL: !reset null

4. docker compose up -d
5. visit http://localhost/?format=ttl in your favorite browser

workaround

Always specify the persistentUrl explicitly, in addition to the clientUrl (or INSTANCE_PERSISTENTURL and INSTANCE_CLIENTURL, respectively).

[dennisvang]

To confuse matters, the format links (see image above) use the rdf subject unless they are overridden using client config as described in the fdp-client docs. This seems redundant to me.