Server list

Swapping certain elements from "ng-show"/"ng-hide" to "ng-if". Should reduce CPU load slightly.

Removed redundant UpdateDigest.

Increased the server insertion batch processing from 50ms to 100ms which shouldn't be noticeable visually but reduce the load of repeatedly looping over every single server every xms.

Author: DarthTealc

garrysmod/html/js/menu/control.Servers.js

@@ -118,7 +118,6 @@ function ControllerServers( $scope, $element, $rootScope, $location )
 		RootScope.CurrentGamemode = gm;
 
 		if ( gm ) gm.server_offset = 0;
-		UpdateDigest( RootScope, 50 );
 	}
 
 	$scope.ServerClass = function( sv )
@@ -553,7 +552,7 @@ function AddServer( type, id, ping, name, desc, map, players, maxplayers, botpla
 
 	RootScope.ServerCount[ type ] += 1;
 
-	UpdateDigest( RootScope, 50 );
+	UpdateDigest( RootScope, 100 );
 }
 
 function MissingGamemodeIcon( element )

garrysmod/html/template/servers.html

@@ -52,7 +52,7 @@
 
 		</div>
 
-		<div class="innerpage" ng-hide="CurrentGamemode != null">
+		<div class="innerpage" ng-if="CurrentGamemode == null">
 
 			<h1 class="menuheader">
 				<span ng-tranny="'servers_gamemodes'"></span>
@@ -62,7 +62,7 @@ <h1 class="menuheader">
 			<div class='server_gamemodes whiterounded'>
 
 				<div class="server_gamemodes_inner scrollable">
-					<div class='gamemode {{gamemode.element_class}}' ng-repeat="gamemode in GamemodeList | filter: gamemodeFilter | orderBy:[GMSort, '-(num_players)', 'name' ]" ng-click="SelectGamemode( gamemode )">
+					<div class='gamemode {{gamemode.element_class}}' ng-repeat="gamemode in GamemodeList | filter: gamemodeFilter | orderBy:[GMSort, '-(num_players)', 'name' ] track by gamemode.name" ng-click="SelectGamemode( gamemode )">
 
 						<img ng-src='../gamemodes/{{gamemode.name}}/icon24.png' onerror="MissingGamemodeIcon( this )"/>
 
@@ -104,7 +104,7 @@ <h1 class="menuheader">
 
 		</div>
 
-		<div class="innerpage" ng-show="CurrentGamemode != null">
+		<div class="innerpage" ng-if="CurrentGamemode != null">
 
 			<h1 class="menuheader">
 				<span>{{GamemodeName(CurrentGamemode)}}</span>
@@ -134,15 +134,15 @@ <h1 class="menuheader">
 
 						<div id="placeholder_pre" style="height: {{CurrentGamemode.server_offset * 22}}px"></div>
 
-						<div ng-repeat="server in CurrentGamemode.servers | orderBy: CurrentGamemode.OrderBy : CurrentGamemode.OrderReverse | filter: serverFilter | startFrom : CurrentGamemode.server_offset | limitTo : ServersPerPage"
+						<div ng-repeat="server in CurrentGamemode.servers | orderBy: CurrentGamemode.OrderBy : CurrentGamemode.OrderReverse | filter: serverFilter | startFrom : CurrentGamemode.server_offset | limitTo : ServersPerPage track by server.address"
 							class="server {{ ServerClass( server ) }} {{IfElse( CurrentGamemode.Selected == server, 'activeserver', '' )}}" ng-mouseup="SelectServer( server, $event )" ng-dblclick="JoinServer( server )">
 
 							<name>
 								<a class='favbutton {{IfElse( server.favorite, "favorited", "" )}}' ng-click="ToggleFavorite( server );$event.stopPropagation();"></a>
-								<img class="flag" ng-src='asset://garrysmod/materials/flags16/{{server.flag}}.png' onerror="MissingFlag( this )" ng-show="server.flag" loading="lazy"/>
-								<img class="passworded" src='img/server-passworded.png' ng-show="server.pass" loading="lazy"/>
+								<img class="flag" ng-src='asset://garrysmod/materials/flags16/{{server.flag}}.png' onerror="MissingFlag( this )" ng-if="server.flag" loading="lazy"/>
+								<img class="passworded" src='img/server-passworded.png' ng-if="server.pass" loading="lazy"/>
 								<span>{{ServerName(server)}}
-									<tag class="{{IfElse( server.version_c > 0, 'future', '' )}}" ng-show="server.version_c != 0">{{IfElse( server.version_c > 0, 'Invalid version', 'Outdated' )}}: {{server.version}}</tag>
+									<tag class="{{IfElse( server.version_c > 0, 'future', '' )}}" ng-if="server.version_c != 0">{{IfElse( server.version_c > 0, 'Invalid version', 'Outdated' )}}: {{server.version}}</tag>
 								</span>
 							</name>
 							<lastvisited ng-hide="server.lastplayed == 0"><lbl ng-tranny="'server_lastvisit'"></lbl> {{server.lastplayedDate}} <span class='lasttime'>{{server.lastplayedTime}}</span></lastvisited>
@@ -159,7 +159,7 @@ <h1 class="menuheader">
 
 				</div>
 
-				<div class='serverinfo' ng-show="CurrentGamemode.Selected">
+				<div class='serverinfo' ng-if="CurrentGamemode.Selected">
 					<span class="closebtn" ng-click="SelectServer( null, $event )"></span>
 					<div>