Fix the bug when the game doesn't launch bc of one or more whitespace(s) in some arguments (for instance the game path) on old version because of a too early remapping of the arguments done before a split

Author: FlowArg

src/main/java/fr/flowarg/openlauncherlib/NoFramework.java

@@ -255,7 +255,7 @@ private String getClassPath(JSONObject vanilla, JSONObject modLoader)
             this.appendLibraries(cp, modLoader);
         this.appendLibraries(cp, vanilla);
 
-        cp.add(this.gameDir.toAbsolutePath().resolve(this.clientJar).toString());
+        cp.add(this.gameDir.resolve(this.clientJar).toAbsolutePath().toString());
 
         return this.toString(cp);
     }
@@ -315,7 +315,14 @@ private List<String> getArguments(JSONObject object, Parameters parameters)
         {
             if(object.isNull("minecraftArguments"))
                 return new ArrayList<>();
-            else return Arrays.asList(this.map(object.getString("minecraftArguments"), parameters).split(" "));
+            else
+            {
+                final String[] arguments = object.getString("minecraftArguments").split(" ");
+                final List<String> result = new ArrayList<>();
+                for (String argument : arguments)
+                    result.add(this.map(argument, parameters));
+                return result;
+            }
         }
         else
         {

src/main/java/fr/theshark34/openlauncherlib/external/ExternalLauncher.java

@@ -137,10 +137,11 @@ public Process launch() throws LaunchException
             vmArgs.addAll(profile.getArgs());
 
         if (profile.getDirectory() != null)
-            builder.directory(profile.getDirectory().toFile());
+            builder.directory(profile.getDirectory().toAbsolutePath().toFile());
 
-        if (profile.isRedirectErrorStream())
-            builder.redirectErrorStream(true);
+        builder.redirectErrorStream(true);
+        builder.redirectError(ProcessBuilder.Redirect.INHERIT);
+        builder.redirectOutput(ProcessBuilder.Redirect.INHERIT);
 
         if (launchingEvent != null)
             launchingEvent.onLaunching(builder);