Merge pull request #7 from Flowpack/bugfix/targetPropertyValue

Sebobo · web-flow · commit f0ddc68ad9d2 · 2022-06-28T08:37:17.000+02:00
BUGFIX: Run unregisterUsageInNode only if $targetPropertyValue is set
diff --git a/Classes/Service/AssetIntegrationService.php b/Classes/Service/AssetIntegrationService.php
@@ -202,7 +202,9 @@ public function beforeNodePublishing(NodeInterface $node, Workspace $targetWorks
             // Unregister the asset stored in the target node, the assets will be registered again after publishing
             if ($targetNode && $targetNode->hasProperty($propertyName)) {
                 $targetPropertyValue = $targetNode->getProperty($propertyName);
-                $this->unregisterUsageInNode($targetNode, $targetPropertyValue, false);
+                if ($targetPropertyValue) {
+                    $this->unregisterUsageInNode($targetNode, $targetPropertyValue, false);
+                }
             }
             $this->unregisterUsageInNode($node, $propertyValue, false);
         }

Original file line number	Diff line number	Diff line change
`@@ -202,7 +202,9 @@ public function beforeNodePublishing(NodeInterface $node, Workspace $targetWorks`
`202`	`202`	`// Unregister the asset stored in the target node, the assets will be registered again after publishing`
`203`	`203`	`if ($targetNode && $targetNode->hasProperty($propertyName)) {`
`204`	`204`	`$targetPropertyValue = $targetNode->getProperty($propertyName);`
`205`		`- $this->unregisterUsageInNode($targetNode, $targetPropertyValue, false);`
	`205`	`+ if ($targetPropertyValue) {`
	`206`	`+ $this->unregisterUsageInNode($targetNode, $targetPropertyValue, false);`
	`207`	`+ }`
`206`	`208`	`}`
`207`	`209`	`$this->unregisterUsageInNode($node, $propertyValue, false);`
`208`	`210`	`}`