Improve documentation of the entity embedder wrapper #304
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 5 commits
April 8, 2025 11:49
Collaborator
Author
|
@essam, it seems you did not notice and I had forgotten this one. In it I already reworked the EntityEmbedder example and integrated the docstring into the "Interface" section. Sorry to trample on your toes, but I have reverted to my original example here. I wanted to follow through with this PR because it also removes the RNN example, which had stopped working, as I explain in the initial post above. |
Collaborator
|
That's completely alright and yes, I indeed missed this one (perhaps, it was best to split this it into two PRs as that would have made easier to merge the EE change but perhaps wait a little on the other for me to fix it). Thank you so much. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #303.
This PR also removes the spam filtering example, which is broken by recent compatibility updates. As it uses RNNs (not officially supported by MLJFlux) and some non-idiomatic MLJ, I could not justify spending more time getting this to work.
@EssamWisam If you can get the spam example to work with latest version of packages listed the Project.toml, then I'll consider a PR to re-instate it.