Add missing dep in useEffect

melvin-chen · melvin-chen · commit f91542a8a8b3 · 2025-01-16T09:38:45.000-08:00
diff --git a/packages/nuka/src/Carousel/Carousel.tsx b/packages/nuka/src/Carousel/Carousel.tsx
@@ -146,7 +146,7 @@ export const Carousel = forwardRef<SlideHandle, CarouselProps>(
           containerRef.current.classList.add('scroll-smooth');
         }
       }
-    }, [currentPage, scrollOffset, beforeSlide, afterSlide]);
+    }, [currentPage, scrollOffset, beforeSlide, afterSlide, initialPage]);
 
     const containerClassName = cls(
       'nuka-container',

Original file line number	Diff line number	Diff line change
`@@ -146,7 +146,7 @@ export const Carousel = forwardRef<SlideHandle, CarouselProps>(`
`146`	`146`	`containerRef.current.classList.add('scroll-smooth');`
`147`	`147`	`}`
`148`	`148`	`}`
`149`		`- }, [currentPage, scrollOffset, beforeSlide, afterSlide]);`
	`149`	`+ }, [currentPage, scrollOffset, beforeSlide, afterSlide, initialPage]);`
`150`	`150`
`151`	`151`	`const containerClassName = cls(`
`152`	`152`	`'nuka-container',`