Remove redundant xTimerStart() in timer_settime (#37)

Saiiijchan · wangfei_chen · web-flow · commit ae1d3f0d5d39 · 2025-02-20T16:37:43.000-08:00
xTimerChangePeriod() already starts the timer.

Signed-off-by: wangfei_chen &lt;wangfei_chen@realsil.com.cn&gt;
Co-authored-by: wangfei_chen &lt;wangfei_chen@realsil.com.cn&gt;
diff --git a/FreeRTOS-Plus-POSIX/source/FreeRTOS_POSIX_timer.c b/FreeRTOS-Plus-POSIX/source/FreeRTOS_POSIX_timer.c
@@ -283,8 +283,7 @@ int timer_settime( timer_t timerid,
         else
         {
             /* Set the timer to expire at the it_value, then start it. */
-            ( void ) xTimerChangePeriod( xTimer, xNextTimerExpiration, portMAX_DELAY );
-            xTimerCommandSent = xTimerStart( xTimer, xNextTimerExpiration );
+            xTimerCommandSent = xTimerChangePeriod( xTimer, xNextTimerExpiration, xNextTimerExpiration );
 
             /* Wait until the timer start command is processed. */
             while( ( xTimerCommandSent != pdFAIL ) && ( xTimerIsTimerActive( xTimer ) == pdFALSE ) )

Original file line number	Diff line number	Diff line change
`@@ -283,8 +283,7 @@ int timer_settime( timer_t timerid,`
`283`	`283`	`else`
`284`	`284`	`{`
`285`	`285`	`/* Set the timer to expire at the it_value, then start it. */`
`286`		`- ( void ) xTimerChangePeriod( xTimer, xNextTimerExpiration, portMAX_DELAY );`
`287`		`- xTimerCommandSent = xTimerStart( xTimer, xNextTimerExpiration );`
	`286`	`+ xTimerCommandSent = xTimerChangePeriod( xTimer, xNextTimerExpiration, xNextTimerExpiration );`
`288`	`287`
`289`	`288`	`/* Wait until the timer start command is processed. */`
`290`	`289`	`while( ( xTimerCommandSent != pdFAIL ) && ( xTimerIsTimerActive( xTimer ) == pdFALSE ) )`