Incorporate review feedback (batched suggestions) # 820

mmerdes · joker234 · mmerdes · commit 5b6135a3214f · 2024-09-13T16:07:34.000+02:00
Co-authored-by: Johannes Visintini &lt;johannes.visintini@heigit.org&gt;
diff --git a/regression-tests/__run_hurl_tests_for_stage.sh b/regression-tests/__run_hurl_tests_for_stage.sh
@@ -5,8 +5,7 @@
 rm -rf report
 mkdir report
 
-hurl *.hurl   --report-html report
-
+hurl *.hurl --report-html report
 printf "\n\nhurl report: file://$PWD/report/index.html\n"
 
 if [[ "$OSTYPE" == "linux-gnu"* ]]; then
diff --git a/regression-tests/hospitals_adminarea_mappingsaturation__no_features.hurl b/regression-tests/hospitals_adminarea_mappingsaturation__no_features.hurl
@@ -1,4 +1,4 @@
-POST {{base_url}}/indicators/mapping-saturation
+POST {{BASE_URL}}/indicators/mapping-saturation
 accept: application/json
 [Options]
 verbose: true
diff --git a/regression-tests/metadata.hurl b/regression-tests/metadata.hurl
@@ -1,4 +1,4 @@
-GET {{base_url}}/metadata?project=all
+GET {{BASE_URL}}/metadata?project=all
 accept: application/json
 [Options]
 verbose: true
diff --git a/regression-tests/roads_adminarea_roadcomparison.hurl b/regression-tests/roads_adminarea_roadcomparison.hurl
@@ -1,4 +1,4 @@
-POST {{base_url}}/indicators/road-comparison
+POST {{BASE_URL}}/indicators/road-comparison
 accept: application/json
 [Options]
 verbose: true
diff --git a/regression-tests/roads_polygon_attributecompleteness.hurl b/regression-tests/roads_polygon_attributecompleteness.hurl
@@ -1,4 +1,4 @@
-POST {{base_url}}/indicators/attribute-completeness
+POST {{BASE_URL}}/indicators/attribute-completeness
 accept: application/json
 [Options]
 verbose: true
diff --git a/regression-tests/roads_polygon_mappingsaturation.hurl b/regression-tests/roads_polygon_mappingsaturation.hurl
@@ -1,4 +1,4 @@
-POST {{base_url}}/indicators/mapping-saturation
+POST {{BASE_URL}}/indicators/mapping-saturation
 accept: application/json
 [Options]
 verbose: true
diff --git a/regression-tests/run_hurl_tests_DEV.sh b/regression-tests/run_hurl_tests_DEV.sh
@@ -1,5 +1,6 @@
+#!/bin/bash
 
-export HURL_base_url=http://127.0.0.1:8080
+export HURL_BASE_URL=http://127.0.0.1:8080
 
 cd "$(dirname "$0")"
 ./__run_hurl_tests_for_stage.sh
diff --git a/regression-tests/run_hurl_tests_PROD.sh b/regression-tests/run_hurl_tests_PROD.sh
@@ -1,5 +1,6 @@
+#!/bin/bash
 
-export HURL_base_url=https://api.quality.ohsome.org/v1
+export HURL_BASE_URL=https://api.quality.ohsome.org/v1
 
 cd "$(dirname "$0")"
 ./__run_hurl_tests_for_stage.sh
diff --git a/regression-tests/run_hurl_tests_TEST.sh b/regression-tests/run_hurl_tests_TEST.sh
@@ -1,5 +1,6 @@
+#!/bin/bash
 
-export HURL_base_url=https://api.quality.ohsome.org/v1-test
+export HURL_BASE_URL=https://api.quality.ohsome.org/v1-test
 
 cd "$(dirname "$0")"
 ./__run_hurl_tests_for_stage.sh

Original file line number	Diff line number	Diff line change
`@@ -1,4 +1,4 @@`
`1`		`-POST {{base_url}}/indicators/mapping-saturation`
	`1`	`+POST {{BASE_URL}}/indicators/mapping-saturation`
`2`	`2`	`accept: application/json`
`3`	`3`	`[Options]`
`4`	`4`	`verbose: true`
Original file line number	Diff line number	Diff line change
`@@ -1,4 +1,4 @@`
`1`		`-GET {{base_url}}/metadata?project=all`
	`1`	`+GET {{BASE_URL}}/metadata?project=all`
`2`	`2`	`accept: application/json`
`3`	`3`	`[Options]`
`4`	`4`	`verbose: true`
Original file line number	Diff line number	Diff line change
`@@ -1,4 +1,4 @@`
`1`		`-POST {{base_url}}/indicators/road-comparison`
	`1`	`+POST {{BASE_URL}}/indicators/road-comparison`
`2`	`2`	`accept: application/json`
`3`	`3`	`[Options]`
`4`	`4`	`verbose: true`
Original file line number	Diff line number	Diff line change
`@@ -1,4 +1,4 @@`
`1`		`-POST {{base_url}}/indicators/attribute-completeness`
	`1`	`+POST {{BASE_URL}}/indicators/attribute-completeness`
`2`	`2`	`accept: application/json`
`3`	`3`	`[Options]`
`4`	`4`	`verbose: true`