Add missing SAL Annotations for improved COM API wrapping

Since the API exposed by some of these headers uses COM, annotating them
with the necessary SAL annotations make it more convenient to generate
comprehensive external bindings for them, such as in Rust:
https://github.com/Traverse-Research/amd-ext-d3d-rs

Author: MarijnS95

AmdDxExt.h

@@ -8,7 +8,7 @@
 /**
 ***************************************************************************************************
 * @file  amddxext.h
-* @brief AMD D3D Exension API include file.
+* @brief AMD D3D Extension API include file.
 ***************************************************************************************************
 */
 #ifndef _AMDDXEXT_H_
@@ -44,4 +44,4 @@ enum AmdDxExtFeatureToken
     AmdDxExtFeature_DeviceCtxSupport            = 3, // Device Ctx Support
 };
 
-#endif // _AMDDXEXT_H_
+#endif // _AMDDXEXT_H_

AmdDxExtApi.h

@@ -8,7 +8,7 @@
 /**
 ***************************************************************************************************
 * @file  amddxextapi.h
-* @brief AMD D3D Exension API include file. This is the main include file for apps using extensions.
+* @brief AMD D3D Extension API include file. This is the main include file for apps using extensions.
 ***************************************************************************************************
 */
 #ifndef _AMDDXEXTAPI_H_
@@ -26,7 +26,7 @@ interface ID3D11Device;
 interface ID3D10Resource;
 interface ID3D11Resource;
 
-// App must use GetProcAddress, etc. to retrive this exported function
+// App must use GetProcAddress, etc. to retrieve this exported function
 // The associated typedef provides a convenient way to define the function pointer
 HRESULT __cdecl AmdDxExtCreate(ID3D10Device* pDevice, IAmdDxExt** ppExt);
 typedef HRESULT (__cdecl *PFNAmdDxExtCreate)(ID3D10Device* pDevice, IAmdDxExt** ppExt);

AmdDxExtIface.h

@@ -10,7 +10,7 @@
 ***************************************************************************************************
 * @file  amddxextiface.h
 * @brief
-*    AMD D3D Exension API include file. This is a helper include file for extensions. It
+*    AMD D3D Extension API include file. This is a helper include file for extensions. It
 *    provides a common base class for all extension interfaces
 ***************************************************************************************************
 */
@@ -38,4 +38,4 @@ class IAmdDxExtInterface
     virtual ~IAmdDxExtInterface() = 0 {};
 };
 
-#endif // _AMDDXEXTIFACE_H_
+#endif // _AMDDXEXTIFACE_H_

AmdDxExtPerfProfile.h

@@ -9,7 +9,7 @@
 ***************************************************************************************************
 * @file  amddxextperfprofile.h
 * @brief
-*    AMD D3D Exension API include file. This is a helper include file for extensions. It
+*    AMD D3D Extension API include file. This is a helper include file for extensions. It
 *    provides a common base class for all extension interfaces
 ***************************************************************************************************
 */

AmdDxExtPerfProfileApi.h

@@ -10,7 +10,7 @@
 ***************************************************************************************************
 * @file  amddxextperfprofileapi.h
 * @brief
-*    AMD D3D Perf Profile Exension API include file.
+*    AMD D3D Perf Profile Extension API include file.
 *    This is the main include file for apps using perf profile extension.
 ***************************************************************************************************
 */

AmdExtD3D.h

@@ -26,7 +26,7 @@
 /**
 ***********************************************************************************************************************
 * @file  AmdExtD3D.h
-* @brief AMD D3D Exension API factory include file.
+* @brief AMD D3D Extension API factory include file.
 ***********************************************************************************************************************
 */
 #pragma once
@@ -45,10 +45,10 @@
 // The app must use GetProcAddress, etc. to retrieve this exported function
 // The associated typedef provides a convenient way to define the function pointer
 HRESULT __cdecl AmdExtD3DCreateInterface(
-    IUnknown*   pOuter,     ///< [in] object on which to base this new interface; usually a D3D device
-    REFIID      riid,       ///< ID of the requested interface
-    void**      ppvObject); ///< [out] The result interface object
-typedef HRESULT (__cdecl *PFNAmdExtD3DCreateInterface)(IUnknown* pOuter, REFIID riid, void** ppvObject);
+    IUnknown*           pOuter,     ///< [in] object on which to base this new interface; usually a D3D device
+    REFIID              riid,       ///< ID of the requested interface
+    _COM_Outptr_ void** ppvObject); ///< [out] The result interface object
+typedef HRESULT (__cdecl *PFNAmdExtD3DCreateInterface)(IUnknown* pOuter, REFIID riid, _COM_Outptr_ void** ppvObject);
 
 /**
 ***********************************************************************************************************************
@@ -62,8 +62,8 @@ IAmdExtD3DFactory : public IUnknown
 {
 public:
     virtual HRESULT CreateInterface(
-        IUnknown* pOuter,           ///< [in] An object on which to base this new interface; the required object type
-                                    ///< is usually a device object but not always
-        REFIID    riid,             ///< The ID of the requested interface
-        void**    ppvObject) = 0;   ///< [out] The result interface object
+        IUnknown*           pOuter,           ///< [in] An object on which to base this new interface; the required object type
+                                              ///< is usually a device object but not always
+        REFIID              riid,             ///< The ID of the requested interface
+        _COM_Outptr_ void** ppvObject) = 0;   ///< [out] The result interface object
 };

AmdExtD3DCommandListMarkerApi.h

@@ -51,4 +51,4 @@ IAmdExtD3DCommandListMarker : public IUnknown
     virtual VOID PopMarker() = 0;
     /// Set a command list marker to indicate a rendering activity
     virtual VOID SetMarker(const char* pMarker) = 0;
-};
+};

AmdExtD3DDeviceApi.h

@@ -25,9 +25,8 @@
 */
 
 #pragma once
-#include "unknwn.h"
+#include <unknwn.h>
 #include <d3d12.h>
-#include "AmdExtD3DDeviceApi.h"
 
 /**
 ***********************************************************************************************************************
@@ -88,7 +87,7 @@ IAmdExtD3DDevice : public IUnknown
         const AmdExtD3DCreateInfo*                  pAmdExtCreateInfo,
         const D3D12_GRAPHICS_PIPELINE_STATE_DESC*   pDesc,
         REFIID                                      riid,
-        void**                                      ppPipelineState) = 0;
+        _COM_Outptr_ void**                         ppPipelineState) = 0;
 };
 
 /**
@@ -103,4 +102,4 @@ IAmdExtD3DDevice1 : public IAmdExtD3DDevice
     virtual VOID PushMarker(ID3D12GraphicsCommandList* pGfxCmdList, const char* pMarker) = 0;
     virtual VOID PopMarker(ID3D12GraphicsCommandList* pGfxCmdList) = 0;
     virtual VOID SetMarker(ID3D12GraphicsCommandList* pGfxCmdList, const char* pMarker) = 0;
-};
+};

AmdExtGpaInterfaceApi.h

@@ -81,7 +81,7 @@ IAmdExtGpaSession : public IUnknown
     virtual UINT32 BeginSample(ID3D12GraphicsCommandList* pGfxCmdList, const AmdExtGpaSampleConfig& config) = 0;
     virtual VOID EndSample(ID3D12GraphicsCommandList* pGfxCmdList, UINT32 sampleId) = 0;
     virtual bool IsReady() const = 0;
-    virtual HRESULT GetResults(UINT32 sampleId, size_t* pSizeInBytes, void *pData) const = 0;
+    virtual HRESULT GetResults(UINT32 sampleId, _Inout_ size_t* pSizeInBytes, _Out_writes_bytes_opt_(*pSizeInBytes) void *pData) const = 0;
     virtual HRESULT Reset() = 0;
     virtual VOID CopyResults(ID3D12GraphicsCommandList* pGfxCmdList) = 0;
 };