Skip to content

Commit 720938e

Browse files
mpflexdanielnaab
andauthored
fix: issue when uploading big pardon form (#635)
--------- Co-authored-by: Daniel Naab <[email protected]>
1 parent cdd0871 commit 720938e

File tree

4 files changed

+22
-21
lines changed

4 files changed

+22
-21
lines changed

packages/design/src/FormManager/FormList/store.ts

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -49,7 +49,6 @@ export const createFormListSlice =
4949
title: fileDetails.name,
5050
description: '',
5151
});
52-
await builder.addDocument(fileDetails);
5352
const result = await context.formService.initializeForm({
5453
summary: {
5554
title: fileDetails.name,

packages/forms/src/documents/__tests__/fill-pdf.test.ts

Lines changed: 14 additions & 13 deletions
Original file line numberDiff line numberDiff line change
@@ -145,18 +145,19 @@ describe('PDF form filler', () => {
145145
});
146146
});
147147

148-
it('returns an error when provided a non-existent field', async () => {
149-
const pdfBytes = await loadSamplePDF('dod_character.pdf');
148+
// We now fail silently see generate.tsLN43-47
149+
// it('returns an error when provided a non-existent field', async () => {
150+
// const pdfBytes = await loadSamplePDF('dod_character.pdf');
150151

151-
const result = (await fillPDF(pdfBytes, {
152-
fakeField: {
153-
type: 'TextField',
154-
value: 'fake data',
155-
},
156-
})) as Failure<string>;
157-
expect(result.success).toEqual(false);
158-
expect(result.error).toEqual(
159-
'PDFDocument has no form field with the name "fakeField"'
160-
);
161-
});
152+
// const result = (await fillPDF(pdfBytes, {
153+
// fakeField: {
154+
// type: 'TextField',
155+
// value: 'fake data',
156+
// },
157+
// })) as Failure<string>;
158+
// expect(result.success).toEqual(false);
159+
// expect(result.error).toEqual(
160+
// 'Error setting form field PDFDocument has no form field with the name "fakeField"'
161+
// );
162+
// });
162163
});

packages/forms/src/documents/pdf/generate.ts

Lines changed: 5 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -40,7 +40,11 @@ export const fillPDF = async (
4040
const form = pdfDoc.getForm();
4141
try {
4242
Object.entries(fieldData).forEach(([name, value]) => {
43-
setFormFieldData(form, value.type, name, value.value);
43+
try {
44+
setFormFieldData(form, value.type, name, value.value);
45+
} catch (error: any) {
46+
console.log('Error setting form field ', error.message);
47+
}
4448
});
4549
} catch (error: any) {
4650
const fieldDataNames = Object.keys(fieldData); // names we got from API

packages/forms/src/patterns/repeater/prompt.ts

Lines changed: 3 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -1,11 +1,8 @@
11
import { type RepeaterPattern } from './index.js';
2-
import {
3-
type CreatePrompt,
4-
type RepeaterProps,
5-
createPromptForPattern,
6-
getPattern,
7-
} from '../../index.js';
82
import { getFormSessionError } from '../../session.js';
3+
import { createPromptForPattern, type CreatePrompt, type RepeaterProps } from '../../components.js';
4+
import { getPattern } from '../../pattern.js';
5+
96
export const createPrompt: CreatePrompt<RepeaterPattern> = (
107
config,
118
session,

0 commit comments

Comments
 (0)