-
Notifications
You must be signed in to change notification settings - Fork 123
Description
The tutorials Simplicial complexes from data points and Simplicial complexes from distance matrix are almost identical.
I propose that we merge them. The Rips complex takes one out of three possible main arguments:
- a pairwise distance matrix that it uses directly for building up the complex;
- a point cloud from which Gudhi computes the pairwise distance matrix before proceeding;
- an OFF file containing the point cloud that is read out first.
So building a Rips complex from data points or from a distance matrix is immediate.
The case of the Alpha complex is less trivial. It theoretically needs a point cloud on which the Delaunay triangulation is computed. As a result, it is natural that the class has a data_points main argument.
It is the current choice of Gudhi to not allow a distance matrix to be passed as argument to the Alpha Complex constructor. The reason seems to be that, on a purely metric space, we then resort to statistical techniques (such as MDS) that push our data from that metric space into an approximate R^p vector space on which a point cloud approximately respecting the original distances between points can be drawn and used to build the Alpha complex.
However, we could add the argument distance_matrix to the Alpha complex constructor, with a proper documentation. In details, we would acknowledge that it is an approximation and that Gudhi uses sklearn.MDS to do that approximation.
What are your thoughts on this ?