Merge pull request #697 from GetStream/on-push

make all components use OnPush change detection

Author: szuperaz

.eslintrc.json

@@ -17,7 +17,7 @@
       ],
       "rules": {
         "@angular-eslint/sort-ngmodule-metadata-arrays": "off",
-        "@angular-eslint/prefer-on-push-component-change-detection": "off",
+        "@angular-eslint/prefer-on-push-component-change-detection": 2,
         "unused-imports/no-unused-imports": "error",
         "no-console": [
           "error",

.github/workflows/workflow.yml

@@ -3,11 +3,11 @@ on:
   push:
     branches:
       - master
-      - 6.x.x-rc
+      - 7.x.x-beta
   pull_request:
     branches:
       - master
-      - 6.x.x-rc
+      - 7.x.x-beta
 jobs:
   workflow:
     runs-on: ubuntu-latest

package.json

@@ -55,7 +55,7 @@
         "channel": "rc"
       }
     ],
-    "dryRun": false,
+    "dryRun": true,
     "plugins": [
       [
         "@semantic-release/commit-analyzer",
@@ -79,7 +79,7 @@
         "@semantic-release/npm",
         {
           "pkgRoot": "./dist/stream-chat-angular",
-          "npmPublish": true
+          "npmPublish": false
         }
       ],
       [

projects/customizations-example/.eslintrc.json

@@ -27,7 +27,8 @@
             "prefix": "app",
             "style": "kebab-case"
           }
-        ]
+        ],
+        "@angular-eslint/prefer-on-push-component-change-detection": "off"
       }
     },
     {

projects/customizations-example/src/app/icon/icon.component.spec.ts

@@ -1,4 +1,5 @@
 import { ComponentFixture, TestBed } from '@angular/core/testing';
+import { ChangeDetectionStrategy } from '@angular/core';
 
 import { IconComponent } from './icon.component';
 
@@ -9,7 +10,11 @@ describe('IconComponent', () => {
   beforeEach(async () => {
     await TestBed.configureTestingModule({
       declarations: [IconComponent],
-    }).compileComponents();
+    })
+      .overrideComponent(IconComponent, {
+        set: { changeDetection: ChangeDetectionStrategy.Default },
+      })
+      .compileComponents();
   });
 
   beforeEach(() => {

projects/customizations-example/src/app/message-action/message-action.component.spec.ts

@@ -1,4 +1,5 @@
 import { ComponentFixture, TestBed } from '@angular/core/testing';
+import { ChangeDetectionStrategy } from '@angular/core';
 
 import { MessageActionComponent } from './message-action.component';
 
@@ -9,7 +10,11 @@ describe('MessageActionComponent', () => {
   beforeEach(async () => {
     await TestBed.configureTestingModule({
       declarations: [MessageActionComponent],
-    }).compileComponents();
+    })
+      .overrideComponent(MessageActionComponent, {
+        set: { changeDetection: ChangeDetectionStrategy.Default },
+      })
+      .compileComponents();
   });
 
   beforeEach(() => {

projects/customizations-example/src/app/thread-header/thread-header.component.spec.ts

@@ -1,4 +1,5 @@
 import { ComponentFixture, TestBed } from '@angular/core/testing';
+import { ChangeDetectionStrategy } from '@angular/core';
 
 import { ThreadHeaderComponent } from './thread-header.component';
 
@@ -9,7 +10,11 @@ describe('ThreadHeaderComponent', () => {
   beforeEach(async () => {
     await TestBed.configureTestingModule({
       declarations: [ThreadHeaderComponent],
-    }).compileComponents();
+    })
+      .overrideComponent(ThreadHeaderComponent, {
+        set: { changeDetection: ChangeDetectionStrategy.Default },
+      })
+      .compileComponents();
   });
 
   beforeEach(() => {

projects/sample-app/.eslintrc.json

@@ -33,7 +33,8 @@
           {
             "patterns": ["dist/*", "public-api"]
           }
-        ]
+        ],
+        "@angular-eslint/prefer-on-push-component-change-detection": "off"
       }
     },
     {

projects/sample-app/src/styles.scss

@@ -61,6 +61,7 @@ body {
 
     .channel-list.thread-close {
       width: 30%;
+      min-width: 30%;
       max-width: 420px;
       position: initial;
       z-index: auto;

projects/stream-chat-angular/src/lib/attachment-list/attachment-list.component.spec.ts

@@ -15,6 +15,7 @@ import { CustomAttachmentListContext, GalleryAttachment } from '../types';
 import { AttachmentConfigurationService } from '../attachment-configuration.service';
 import {
   AfterViewInit,
+  ChangeDetectionStrategy,
   Component,
   SimpleChange,
   TemplateRef,
@@ -63,7 +64,11 @@ describe('AttachmentListComponent', () => {
         MessageService,
       ],
       imports: [TranslateModule.forRoot()],
-    }).compileComponents();
+    })
+      .overrideComponent(AttachmentListComponent, {
+        set: { changeDetection: ChangeDetectionStrategy.Default },
+      })
+      .compileComponents();
     TestBed.inject(StreamI18nService).setTranslation();
   });