Skip to content

Commit 2f26d0d

Browse files
authored
Better exception (#156)
* preserve exception stacktrace * fix import
1 parent 91f9173 commit 2f26d0d

File tree

2 files changed

+7
-4
lines changed

2 files changed

+7
-4
lines changed

getstream/video/rtc/connection_manager.py

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -329,12 +329,12 @@ async def _connect_internal(
329329
sfu_event.join_response.fast_reconnect_deadline_seconds
330330
)
331331
else:
332-
logger.warning(f"No join response from WebSocket: {sfu_event}")
332+
logger.exception(f"No join response from WebSocket: {sfu_event}")
333333

334334
logger.debug(f"WebSocket connected successfully to {ws_url}")
335335
except Exception as e:
336-
logger.error(f"Failed to connect WebSocket to {ws_url}: {e}")
337-
raise SfuConnectionError(f"WebSocket connection failed: {e}")
336+
logger.exception(f"Failed to connect WebSocket to {ws_url}: {e}")
337+
raise SfuConnectionError(f"WebSocket connection failed: {e}") from e
338338

339339
# Step 5: Create SFU signaling client
340340
twirp_server_url = self.join_response.data.credentials.server.url

getstream/video/rtc/connection_utils.py

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -220,7 +220,10 @@ async def create_join_request(token: str, session_id: str) -> events_pb2.JoinReq
220220
A JoinRequest protobuf message configured with data
221221
"""
222222

223-
from video.rtc.pc import subscribe_codec_preferences, publish_codec_preferences
223+
from getstream.video.rtc.pc import (
224+
subscribe_codec_preferences,
225+
publish_codec_preferences,
226+
)
224227

225228
# Create a JoinRequest
226229
join_request = events_pb2.JoinRequest()

0 commit comments

Comments
 (0)