core: fix incorrect dpr used for responsive images advice (#16771)

Author: connorjclark

cli/test/smokehouse/test-definitions/byte-efficiency.js

@@ -214,7 +214,7 @@ const expectations = {
           //   },
           // ],
           debugData: {
-            wastedBytes: '160000 +/- 10000',
+            wastedBytes: '132000 +/- 10000',
           },
         },
       },

cli/test/smokehouse/test-definitions/dobetterweb.js

@@ -351,42 +351,42 @@ const expectations = {
         score: '<0.5',
         metricSavings: {LCP: '>2000'},
         details: {
-          debugData: {wastedBytes: '>1200000'},
+          debugData: {wastedBytes: '>1100000'},
           items: [
             {
               url: 'http://localhost:10200/dobetterweb/lighthouse-rotating.gif',
               totalBytes: 934285,
-              wastedBytes: 682028,
+              wastedBytes: '682028 +/- 10000',
               subItems: {items: [{reason: /Using video formats instead of GIFs/}]},
             },
             {
               url: 'http://localhost:10200/dobetterweb/lighthouse-1024x680.jpg?iar1', // filename is a lie...
               totalBytes: 112710,
-              wastedBytes: 112418,
+              wastedBytes: '111815 +/- 10000',
               subItems: {items: [{reason: /This image file is larger than it needs to be \(1024x678\) for its displayed dimensions/}]},
             },
             {
               url: 'http://localhost:10200/dobetterweb/lighthouse-1024x680.jpg?isr2',
               totalBytes: 112710,
-              wastedBytes: 111152,
+              wastedBytes: '107937 +/- 10000',
               subItems: {items: [{reason: /This image file is larger than it needs to be \(1024x678\) for its displayed dimensions/}]},
             },
             {
               url: 'http://localhost:10200/dobetterweb/lighthouse-1024x680.jpg?iar2',
               totalBytes: 112710,
-              wastedBytes: 111152,
+              wastedBytes: '107937 +/- 10000',
               subItems: {items: [{reason: /This image file is larger than it needs to be \(1024x678\) for its displayed dimensions/}]},
             },
             {
               url: 'http://localhost:10200/dobetterweb/lighthouse-1024x680.jpg?isr3',
               totalBytes: 112710,
-              wastedBytes: 98684,
+              wastedBytes: '69754 +/- 30000',
               subItems: {items: [{reason: /This image file is larger than it needs to be \(1024x678\) for its displayed dimensions/}]},
             },
             {
               url: 'http://localhost:10200/dobetterweb/lighthouse-1024x680.jpg',
               totalBytes: 112710,
-              wastedBytes: 98684,
+              wastedBytes: '69754 +/- 30000',
               subItems: {items: [{reason: /This image file is larger than it needs to be \(1024x678\) for its displayed dimensions/}]},
             },
           ],

core/audits/audit.js

@@ -496,9 +496,9 @@ class Audit {
     const trace = artifacts.Trace;
     const devtoolsLog = artifacts.DevtoolsLog;
     const gatherContext = artifacts.GatherContext;
-    const {URL, SourceMaps} = artifacts;
+    const {URL, HostDPR, SourceMaps} = artifacts;
     // eslint-disable-next-line max-len
-    return {trace, devtoolsLog, gatherContext, settings: context.settings, URL, SourceMaps, simulator: null};
+    return {trace, devtoolsLog, gatherContext, settings: context.settings, URL, SourceMaps, HostDPR, simulator: null};
   }
 }
 

core/audits/bootup-time.js

@@ -49,7 +49,7 @@ class BootupTime extends Audit {
       description: str_(UIStrings.description),
       scoreDisplayMode: Audit.SCORING_MODES.METRIC_SAVINGS,
       guidanceLevel: 1,
-      requiredArtifacts: ['Trace', 'DevtoolsLog', 'URL', 'GatherContext', 'SourceMaps'],
+      requiredArtifacts: ['Trace', 'DevtoolsLog', 'URL', 'GatherContext', 'SourceMaps', 'HostDPR'],
     };
   }
 

core/audits/byte-efficiency/unminified-css.js

@@ -38,7 +38,7 @@ class UnminifiedCSS extends ByteEfficiencyAudit {
       scoreDisplayMode: ByteEfficiencyAudit.SCORING_MODES.METRIC_SAVINGS,
       guidanceLevel: 3,
       requiredArtifacts: ['Stylesheets', 'DevtoolsLog', 'Trace', 'URL', 'GatherContext',
-        'SourceMaps'],
+        'SourceMaps', 'HostDPR'],
     };
   }
 

core/audits/byte-efficiency/unminified-javascript.js

@@ -45,7 +45,7 @@ class UnminifiedJavaScript extends ByteEfficiencyAudit {
       scoreDisplayMode: ByteEfficiencyAudit.SCORING_MODES.METRIC_SAVINGS,
       guidanceLevel: 3,
       requiredArtifacts: ['Scripts', 'DevtoolsLog', 'Trace', 'GatherContext', 'URL',
-        'SourceMaps'],
+        'SourceMaps', 'HostDPR'],
     };
   }
 

core/audits/byte-efficiency/unused-css-rules.js

@@ -34,8 +34,8 @@ class UnusedCSSRules extends ByteEfficiencyAudit {
       description: str_(UIStrings.description),
       scoreDisplayMode: ByteEfficiencyAudit.SCORING_MODES.METRIC_SAVINGS,
       guidanceLevel: 1,
-      requiredArtifacts:
-        ['Stylesheets', 'CSSUsage', 'URL', 'DevtoolsLog', 'Trace', 'GatherContext', 'SourceMaps'],
+      // eslint-disable-next-line max-len
+      requiredArtifacts: ['Stylesheets', 'CSSUsage', 'URL', 'DevtoolsLog', 'Trace', 'GatherContext', 'SourceMaps', 'HostDPR'],
     };
   }
 

core/audits/byte-efficiency/unused-javascript.js

@@ -69,7 +69,7 @@ class UnusedJavaScript extends ByteEfficiencyAudit {
       scoreDisplayMode: ByteEfficiencyAudit.SCORING_MODES.METRIC_SAVINGS,
       guidanceLevel: 1,
       requiredArtifacts: ['JsUsage', 'Scripts', 'SourceMaps', 'GatherContext',
-        'DevtoolsLog', 'Trace', 'URL', 'SourceMaps'],
+        'DevtoolsLog', 'Trace', 'URL', 'HostDPR'],
     };
   }
 

core/audits/insights/cache-insight.js

@@ -24,7 +24,7 @@ class CacheInsight extends Audit {
       failureTitle: str_(UIStrings.title),
       description: str_(UIStrings.description),
       guidanceLevel: 3,
-      requiredArtifacts: ['Trace', 'SourceMaps'],
+      requiredArtifacts: ['Trace', 'SourceMaps', 'HostDPR'],
       replacesAudits: ['uses-long-cache-ttl'],
     };
   }

core/audits/insights/cls-culprits-insight.js

@@ -37,7 +37,7 @@ class CLSCulpritsInsight extends Audit {
       failureTitle: insightStr_(InsightUIStrings.title),
       description: insightStr_(InsightUIStrings.description),
       guidanceLevel: 3,
-      requiredArtifacts: ['Trace', 'TraceElements', 'SourceMaps'],
+      requiredArtifacts: ['Trace', 'TraceElements', 'SourceMaps', 'HostDPR'],
       replacesAudits: ['layout-shifts'],
     };
   }