Update spotbugs excludes filter (#189)

* Latest google_checks

* Updates to google_checks 8.36.1 from 8.30
* App should pass - fix test/App.java
* test/ should use Java 11
* add skipTests property - override w/ -DskipTests=true Fixes #134

* Update spotBugsExcludeFilter.xml

Update the excludeList based on fixes #136 & #171

Author: lesv

checkstyle-config/src/main/resources/c.g.c.s/spotBugsExcludeFilter.xml

@@ -25,19 +25,28 @@ see https://spotbugs.readthedocs.io/en/stable/bugDescriptions.html
   xmlns="https://github.com/spotbugs/filter/3.0.0"
   xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance"
   xsi:schemaLocation="https://github.com/spotbugs/filter/3.0.0 https://raw.githubusercontent.com/spotbugs/spotbugs/3.1.0/spotbugs/etc/findbugsfilter.xsd">
+  <!--      <Bug pattern="DLS_DEAD_LOCAL_STORE" />-->
+
+  <Match> <!-- Global excludes https://github.com/GoogleCloudPlatform/java-repo-tools/issues/136 -->
+    <Or>
+      <Bug pattern="IMC_IMMATURE_CLASS_NO_TOSTRING" /> <!-- Let me skip toString() -->
+      <Bug pattern="CRLF_INJECTION_LOGS" /> <!-- Let me inject /n/r into logs -->
+    </Or>
+  </Match>
+
   <Match>
-    <!-- TODO: Remove once SpotBugs fully supports Java 11 (JENKINS-53720) -->
-    <!-- JDK 11 generates a different binary code than expected by SpotBugs -->
-    <!-- https://github.com/spotbugs/spotbugs/issues/756 -->
-    <Bug pattern="RCN_REDUNDANT_NULLCHECK_WOULD_HAVE_BEEN_A_NPE"/>
+    <!-- https://github.com/GoogleCloudPlatform/java-repo-tools/issues/171 -->
+    <!-- query watch where a callback has to be supplied (sure it could be a separate class from a
+         type signature standpoint, but that moves the code away from the sample) -->
+    <Bug pattern="SIC_INNER_SHOULD_BE_STATIC_ANON" />
   </Match>
-  <!-- From https://github.com/GoogleCloudPlatform/java-repo-tools/issues/123 -->
-  <!-- https://github.com/GoogleCloudPlatform/java-docs-samples/pull/2630#issuecomment-612320968 -->
-  <!--      <Bug pattern="IMC_IMMATURE_CLASS_NO_TOSTRING" />-->
-  <!--      <Bug pattern="CRLF_INJECTION_LOGS" />-->
-  <!--      <Bug pattern="LI_LAZY_INIT_STATIC" />-->
-  <!--      <Bug pattern="DLS_DEAD_LOCAL_STORE" />-->
 
+  <Match>
+    <!-- https://github.com/GoogleCloudPlatform/java-repo-tools/issues/171 -->
+    <!-- code in question is creating the initial dataset to show how queries work, and
+         necessarily have to call the same methods a few times -->
+    <Bug pattern="PRMC_POSSIBLY_REDUNDANT_METHOD_CALLS" />
+  </Match>
   <Match>
     <!-- https://github.com/spotbugs/spotbugs/issues/735 -->
     <Bug pattern="UPM_UNCALLED_PRIVATE_METHOD"/>
@@ -48,15 +57,36 @@ see https://spotbugs.readthedocs.io/en/stable/bugDescriptions.html
   </Match>
 
   <Match>
-    <!-- Samples uses this idiom a lot, so I'm turning it off -->
+    <!-- Samples uses this idiom a lot -->
     <Bug pattern="CLI_CONSTANT_LIST_INDEX"/>
   </Match>
-  <Match>
-    <!-- https://github.com/spotbugs/spotbugs/issues/925 -->
-    <Bug pattern="PCOA_PARTIALLY_CONSTRUCTED_OBJECT_ACCESS"/>
-  </Match>
+
   <Match>
     <!-- https://github.com/spotbugs/spotbugs/issues/293 -->
     <Bug pattern="OBL_UNSATISFIED_OBLIGATION"/>
   </Match>
+  <Match>
+    <!-- https://github.com/GoogleCloudPlatform/java-repo-tools/issues/136 -->
+    <Bug pattern="SE_NO_SERIALVERSIONID" />
+  </Match>
+  <Match>
+    <!-- https://github.com/GoogleCloudPlatform/java-repo-tools/issues/136 -->
+    <Bug pattern="SERVLET_PARAMETER" />
+  </Match>
+  <Match>
+    <!-- https://github.com/GoogleCloudPlatform/java-repo-tools/issues/136 -->
+    <Bug pattern="WEM_WEAK_EXCEPTION_MESSAGING" />
+  </Match>
+  <Match>
+    <!-- https://github.com/GoogleCloudPlatform/java-repo-tools/issues/136 -->
+    <Bug pattern="ODR_OPEN_DATABASE_RESOURCE" />
+  </Match>
+  <Match>
+    <!-- https://github.com/GoogleCloudPlatform/java-repo-tools/issues/136 -->
+    <Bug pattern="XSS_SERVLET" />
+  </Match>
+  <Match>
+    <!-- https://github.com/GoogleCloudPlatform/java-repo-tools/issues/136 -->
+    <Bug pattern="HARD_CODE_PASSWORD" />
+  </Match>
 </FindBugsFilter>

pom.xml

@@ -29,6 +29,7 @@ limitations under the License.
     <versions-maven-plugin>2.7</versions-maven-plugin>
     <maven-gpg-plugin>1.6</maven-gpg-plugin>
     <pmdVersion>6.27.0</pmdVersion>
+    <skipTests>false</skipTests>
   </properties>
 
   <groupId>com.google.cloud.samples</groupId>
@@ -344,6 +345,7 @@ limitations under the License.
         <artifactId>maven-surefire-plugin</artifactId>
         <version>3.0.0-M5</version>
         <configuration>
+          <skipTests>${skipTests}</skipTests>
           <reportNameSuffix>sponge_log</reportNameSuffix>
           <trimStackTrace>false</trimStackTrace>
         </configuration>

test/pom.xml

@@ -31,8 +31,8 @@ limitations under the License.
   </parent>
 
   <properties>
-    <maven.compiler.source>1.8</maven.compiler.source> <!-- REQUIRED -->
-    <maven.compiler.target>1.8</maven.compiler.target> <!-- REQUIRED -->
+    <maven.compiler.source>11</maven.compiler.source> <!-- REQUIRED -->
+    <maven.compiler.target>11</maven.compiler.target> <!-- REQUIRED -->
   </properties>
 
   <dependencies>

test/src/main/java/com/google/cloud/samples/test/App.java

@@ -16,14 +16,16 @@
 
 package com.google.cloud.samples.test;
 
+import java.time.LocalDateTime;
+
 /** A hello world app to test the parent pom.xml. */
 public class App {
   public static void main(String[] args) {
     App app = new App();
     System.out.println(app.greeting());
   }
 
-  public String greeting() {
-    return "Hello World!";
+  private String greeting() {
+    return "Hello World! " + LocalDateTime.now();
   }
 }

third_party/checkstyle/METADATA

@@ -13,7 +13,7 @@ third_party {
     type: GIT
     value: "https://github.com/checkstyle/checkstyle"
   }
-  version: "8.30"
-  last_upgrade_date { year: 2020 month: 3 day: 5 }
+  version: "8.36.1"
+  last_upgrade_date { year: 2020 month: 9 day: 22 }
   local_modifications: "RegexpHeader, severity, SupressWaringsHolder, and SuppressionCommentFilter"
 }