const return, static casting

Author: GrantComm

ui/dive_tree_view.h

@@ -54,8 +54,9 @@ class DiveFilterModel : public QSortFilterProxyModel
     DiveFilterModel(const Dive::CommandHierarchy &command_hierarchy, QObject *parent = nullptr);
     void SetMode(FilterMode filter_mode);
     void CollectGfxrDrawCallIndices(const QModelIndex &parent_index = QModelIndex());
-    std::vector<uint64_t> GetPm4DrawCallIndices() { return m_pm4_draw_call_indices; }
-    std::vector<uint64_t> GetGfxrDrawCallIndices() { return m_gfxr_draw_call_indices; }
+    void AddPm4DrawCallIndex(uint64_t index) const;
+    const std::vector<uint64_t>& GetPm4DrawCallIndices() { return m_pm4_draw_call_indices; }
+    const std::vector<uint64_t>& GetGfxrDrawCallIndices() { return m_gfxr_draw_call_indices; }
 public slots:
     void applyNewFilterMode(FilterMode new_mode);
 
@@ -66,7 +67,7 @@ public slots:
     const Dive::CommandHierarchy &m_command_hierarchy;
     FilterMode                    m_filter_mode = kNone;
     mutable std::vector<uint64_t> m_pm4_draw_call_indices;
-    mutable std::vector<uint64_t> m_gfxr_draw_call_indices;
+    std::vector<uint64_t> m_gfxr_draw_call_indices;
 };
 
 //--------------------------------------------------------------------------------------------------

ui/gfxr_vulkan_command_arguments_tab_view.cpp

@@ -118,7 +118,7 @@ void GfxrVulkanCommandArgumentsTabView::OnSelectionChanged(const QModelIndex &in
     // Always use the source_index, regardless of whether a proxy was involved.
     m_arg_proxy_model->SetTargetParentSourceIndex(source_index);
 
-    uint32_t column_count = (uint32_t)m_command_hierarchy_model->columnCount(QModelIndex());
+    uint32_t column_count = static_cast<uint32_t>(m_command_hierarchy_model->columnCount(QModelIndex()));
     for (uint32_t column = 0; column < column_count; ++column)
         m_command_hierarchy_view->resizeColumnToContents(column);