Code review

Author: Keavon

editor/src/messages/input_mapper/utility_types/input_mouse.rs

@@ -148,4 +148,4 @@ pub enum MouseButton {
 	Forward,
 }
 
-pub const NUMBER_OF_MOUSE_BUTTONS: usize = 3;
+pub const NUMBER_OF_MOUSE_BUTTONS: usize = 5; // Should be the number of variants in MouseButton

editor/src/messages/portfolio/document/document_message_handler.rs

@@ -256,7 +256,7 @@ impl MessageHandler<DocumentMessage, DocumentMessageData<'_>> for DocumentMessag
 				graph_operation_message_handler.process_message(message, responses, data);
 			}
 			DocumentMessage::AlignSelectedLayers { axis, aggregate } => {
-				let axis: DVec2 = match axis {
+				let axis = match axis {
 					AlignAxis::X => DVec2::X,
 					AlignAxis::Y => DVec2::Y,
 				};

editor/src/messages/portfolio/document/utility_types/network_interface.rs

@@ -1503,11 +1503,13 @@ impl NodeNetworkInterface {
 	pub fn start_transaction(&mut self) {
 		self.transaction_status = TransactionStatus::Started;
 	}
+
 	pub fn transaction_modified(&mut self) {
 		if self.transaction_status == TransactionStatus::Started {
 			self.transaction_status = TransactionStatus::Modified;
 		}
 	}
+
 	pub fn finish_transaction(&mut self) {
 		self.transaction_status = TransactionStatus::Finished;
 	}

editor/src/messages/portfolio/menu_bar/menu_bar_message_handler.rs

@@ -189,6 +189,8 @@ impl LayoutHolder for MenuBarMessageHandler {
 							disabled: no_active_document,
 							..MenuBarEntry::default()
 						},
+					],
+					vec![
 						MenuBarEntry {
 							label: "Previous Selection".into(),
 							shortcut: action_keys!(DocumentMessageDiscriminant::SelectionStepBack),

editor/src/messages/tool/tool_messages/gradient_tool.rs

@@ -111,7 +111,9 @@ enum GradientToolFsmState {
 fn gradient_space_transform(layer: LayerNodeIdentifier, document: &DocumentMessageHandler) -> DAffine2 {
 	let bounds = document.metadata().nonzero_bounding_box(layer);
 	let bound_transform = DAffine2::from_scale_angle_translation(bounds[1] - bounds[0], 0., bounds[0]);
+
 	let multiplied = document.metadata().transform_to_viewport(layer);
+
 	multiplied * bound_transform
 }
 

editor/src/messages/tool/tool_messages/path_tool.rs

@@ -619,6 +619,7 @@ impl Fsm for PathToolFsmState {
 						}
 					}
 				}
+
 				responses.add(DocumentMessage::EndTransaction);
 				responses.add(PathToolMessage::SelectedPointUpdated);
 				tool_data.snap_manager.cleanup(responses);

editor/src/messages/tool/tool_messages/select_tool.rs

@@ -543,6 +543,7 @@ impl Fsm for SelectToolFsmState {
 					.collect();
 				let intersection_list = document.click_list(input).collect::<Vec<_>>();
 				let intersection = document.find_deepest(&intersection_list);
+
 				// If the user is dragging the bounding box bounds, go into ResizingBounds mode.
 				// If the user is dragging the rotate trigger, go into RotatingBounds mode.
 				// If the user clicks on a layer that is in their current selection, go into the dragging mode.
@@ -631,6 +632,7 @@ impl Fsm for SelectToolFsmState {
 					} else {
 						tool_data.select_single_layer = intersection.and_then(|intersection| intersection.ancestors(document.metadata()).find(|ancestor| selected.contains(ancestor)));
 					}
+					
 					tool_data.layers_dragging = selected;
 
 					tool_data.get_snap_candidates(document, input);

editor/src/messages/tool/tool_messages/spline_tool.rs

@@ -229,6 +229,7 @@ impl Fsm for SplineToolFsmState {
 			}
 			(SplineToolFsmState::Drawing, SplineToolMessage::DragStop) => {
 				responses.add(DocumentMessage::EndTransaction);
+
 				let Some(layer) = tool_data.layer else {
 					return SplineToolFsmState::Ready;
 				};