Skip to content

Make CI reject an out-of-date Cargo.lock manifest #3101

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Aug 28, 2025
Merged

Make CI reject an out-of-date Cargo.lock manifest #3101

merged 4 commits into from
Aug 28, 2025

Conversation

Firestar99
Copy link
Collaborator

No description provided.

@Firestar99 Firestar99 changed the title ci: detect out of date Cargo.lock CI: detect out of date Cargo.lock Aug 27, 2025
@Firestar99 Firestar99 mentioned this pull request Aug 27, 2025
Draft
@Firestar99 Firestar99 marked this pull request as ready for review August 27, 2025 15:04
@Keavon Keavon changed the title CI: detect out of date Cargo.lock Make CI detect out-of-date Cargo.lock manifests Aug 27, 2025
@Keavon Keavon changed the title Make CI detect out-of-date Cargo.lock manifests Make CI reject out-of-date Cargo.lock manifests Aug 27, 2025
@Keavon Keavon changed the title Make CI reject out-of-date Cargo.lock manifests Make CI reject an out-of-date Cargo.lock manifest Aug 27, 2025
Keavon
Keavon previously approved these changes Aug 27, 2025
View reviewed changes
@Keavon Keavon enabled auto-merge (squash) August 27, 2025 21:24
@Keavon Keavon disabled auto-merge August 27, 2025 21:43
@Keavon
Copy link
Member

Keavon commented Aug 27, 2025

capture

@Keavon Keavon self-requested a review August 27, 2025 22:49
@Firestar99
Copy link
Collaborator Author

Firestar99 commented Aug 27, 2025 •
edited
Loading

@Keavon That's due to the Cargo.toml on master being out of date, after #3090 got merged (probably a bad rebase on my end). Merging this PR will both update the Cargo.toml as well as prevent future breakage.

@Keavon Keavon merged commit a199a5f into master Aug 28, 2025
4 checks passed
@Keavon Keavon deleted the fix-ci branch August 28, 2025 00:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Keavon Keavon Keavon approved these changes

@TrueDoctor TrueDoctor Awaiting requested review from TrueDoctor

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Firestar99 @Keavon