-
-
Notifications
You must be signed in to change notification settings - Fork 948
Desktop: Forward the pointer leave event to CEF #3197
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Desktop: Forward the pointer leave event to CEF #3197
Conversation
desktop/src/cef/input.rs
Outdated
} | ||
|
||
let Some(host) = browser.host() else { | ||
return; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Make this a one-liner, please.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is from auto formating
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The one-liner version is short enough, so you can remove the semicolon and it'll stay as a one-liner.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
did not know that. thx
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If the line becomes long enough, it'll force it back to three lines, but it's usually worth trying to get the short version. Occasionally you'll have a bunch of long lines mixed in with one short line, in which case I usually opt for consistency to let them all be the three-liner, but otherwise prefer attempting to get the short version if nearby consistency isn't a concern.
@TrueDoctor do you understand why profiling is broken again? |
I would assume a non-upgraded demo artwork |
No description provided.