Skip to content

Conversation

timon-schelling
Copy link
Member

No description provided.

@Keavon Keavon changed the title Desktop: Forward pointer leave to CEF Desktop: Forward the pointer leave event to CEF Sep 19, 2025
@timon-schelling timon-schelling marked this pull request as ready for review September 19, 2025 20:39
}

let Some(host) = browser.host() else {
return;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Make this a one-liner, please.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is from auto formating

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The one-liner version is short enough, so you can remove the semicolon and it'll stay as a one-liner.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

did not know that. thx

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If the line becomes long enough, it'll force it back to three lines, but it's usually worth trying to get the short version. Occasionally you'll have a bunch of long lines mixed in with one short line, in which case I usually opt for consistency to let them all be the three-liner, but otherwise prefer attempting to get the short version if nearby consistency isn't a concern.

@timon-schelling
Copy link
Member Author

@TrueDoctor do you understand why profiling is broken again?

@TrueDoctor
Copy link
Member

@TrueDoctor do you understand why profiling is broken again?

I would assume a non-upgraded demo artwork

@timon-schelling timon-schelling enabled auto-merge (squash) September 21, 2025 10:09
@timon-schelling timon-schelling merged commit 09bc891 into master Sep 21, 2025
3 of 4 checks passed
@timon-schelling timon-schelling deleted the desktop-implement-missing-pointer-leave branch September 21, 2025 10:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants