Ensure the LoadPreferences message is dispatched with None when no preferences exist #3198
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
timon-schelling
changed the title
Keavon
changed the title
Keavon
reviewed
Sep 23, 2025
Keavon
reviewed
Sep 23, 2025
| log::error!("Failed to deserialize preferences"); | ||
| return; | ||
| pub fn load_preferences(&self, preferences: Option<String>) { | ||
| let preferences = if let Some(preferences) = preferences { |
There was a problem hiding this comment.
I think this should be a .map() instead of if-let-else?
There was a problem hiding this comment.
Oh, I guess you need to not be in a closure for the early return.
Keavon
approved these changes
Sep 23, 2025
timon-schelling
force-pushed
the
preference-load-message-on-default-load
branch
from
0025675 to
fd1c67d
Compare
|
I haven't QA'd this but my review concerns are addressed so you may merge anytime. |
|
Was waiting on rust-gpu ci issue fix. Did testing locally. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, when no preferences were stored, the Load Preferences message was never called. This caused issues with hole-punch setting on desktop not being set correctly. Users had to manually go into settings and toggle Vello off and back on for it to take effect.
This PR fixes the issue by always sending a Load Preferences message from both frontends, even when there are no saved preferences. In that case, preferences are set to None to explicitly indicate that nothing was loaded (default preferences will be used).