Network node/Merged nodes have no input types, cant edit input name, when creating new inputs from inside

[laundmo]

When I create a custom node and create inputs from inside the node, its input types are always () and I cannot edit the input name.

After I connect the correct types from the outside, and they're known, they stay and I can now edit the input names.

This leads to a very annoying workflow of: add new input inside node, exit node, add value of correct type, enter node, edit input name, repeat.

[Keavon]

Yeah, we need these to display a chosen widget.

[laundmo]

Yeah, we need these to display a chosen widget.

Honestly, the first step should be some kind of simple backwards inference of "if input leads to type A, input is type A" so they're not stuck on type () until a type is connected from outside

[laundmo]

I just noticed something:

As soon as it has some type other than () for the first time, the inference i'm talking about works! I can connect a input that was one type to a node of another type and it switches type and name over!

That means its already implemented somewhere, its just a matter of the default () type breaking it somehow.

[adamgerhant]

Are you using dev.graphite.rs? I am able to create a new import from within the node and rename it by doubling clicking the "import index _" label. It also wouldnt be possible to have backward inference, since the () type is only for inputs that are disconnected. In order to have a drop down for the type, PR #2822 can be adapted to also be available on the imports.

[Keavon]

@adamgerhant This issue and the requested fix is the topic we discussed a month or two ago.

[adamgerhant]

For the input types I believe we will have a dropdown for possible input types, but I’m not sure where this list will be sourced from. There would also be a drop down to select the tagged value on the encapsulating input, which would be similar to the value node PR.

The input naming part seems to be fixed though, and back inference of types could be possible when connecting an import to an exposed value input. A more detailed issue and feature description would be useful.

[laundmo]

Are you using dev.graphite.rs?

yes.

and rename it by doubling clicking the "import index _" label.

i can try to edit the name, but it resets when i click outside

It also wouldnt be possible to have backward inference, since the () type is only for inputs that are disconnected.

A simple fix might be setting the type to anything other than () by default, as it already automatically determines the type once the input has been changed away from () once by connecting something from outside.

repro:

1. create new network node and enter it
2. add input
3. connect inout to some node
4. exit network node
5. connect output of any node to the input (i just use a value node)
6. now the input gets a type
7. remove the connection again
8. enter the network node
9. connect the input to various types
10. you should see that the inout type is adjusted automatically now, based on what its connected to

The input naming part seems to be fixed though

I can name inputs once their type is not () anymore. It seems to me that the () type is somehow at fault for both these related problems - another sign that a fix could be to use any other type than () for new inputs.