Skip to content

Conversation

luarmr
Copy link
Contributor

@luarmr luarmr commented Sep 19, 2025

🎯 Purpose
Remove unnecessary LSO server dependency from the yarn e2e workflow to simplify CI pipeline and reduce potential failure points.

πŸ“‹ Changes
❌ Removed "Run LSO server" step that starts Docker container
❌ Removed corresponding "Kill LSO server" cleanup step
βœ… Maintained all frontend e2e testing capabilities
βœ… Reduced workflow complexity and execution time

πŸ” Background
The e2e workflow was starting a full Label Studio backend server via Docker, but the frontend e2e tests don't actually require backend connectivity. This was adding unnecessary complexity, Docker dependencies, and potential failure points to our CI pipeline.

βœ… Testing
[x] Verified workflow runs successfully with act - current pr too
[x] Confirmed frontend e2e tests pass without backend server
[x] Validated no tests depend on LSO server endpoints
[x] Checked workflow execution time improvement

@luarmr luarmr requested a review from a team as a code owner September 19, 2025 22:49
Copy link

netlify bot commented Sep 19, 2025

βœ… Deploy Preview for label-studio-docs-new-theme canceled.

Name Link
πŸ”¨ Latest commit 3eb6493
πŸ” Latest deploy log https://app.netlify.com/projects/label-studio-docs-new-theme/deploys/68cdde0d0a74f20008c19ed5

Copy link

netlify bot commented Sep 19, 2025

βœ… Deploy Preview for label-studio-storybook canceled.

Name Link
πŸ”¨ Latest commit 3eb6493
πŸ” Latest deploy log https://app.netlify.com/projects/label-studio-storybook/deploys/68cdde0da555950008d19858

@github-actions github-actions bot added the ci label Sep 19, 2025
Copy link

netlify bot commented Sep 19, 2025

βœ… Deploy Preview for label-studio-playground canceled.

Name Link
πŸ”¨ Latest commit 3eb6493
πŸ” Latest deploy log https://app.netlify.com/projects/label-studio-playground/deploys/68cdde0da4b2cd000813640f

Copy link

netlify bot commented Sep 19, 2025

βœ… Deploy Preview for heartex-docs canceled.

Name Link
πŸ”¨ Latest commit 3eb6493
πŸ” Latest deploy log https://app.netlify.com/projects/heartex-docs/deploys/68cdde0da4b2cd000813640b

Copy link

codecov bot commented Sep 19, 2025

Codecov Report

βœ… All modified and coverable lines are covered by tests.
βœ… Project coverage is 60.53%. Comparing base (c9a270d) to head (3eb6493).
⚠️ Report is 3 commits behind head on develop.

❗ There is a different number of reports uploaded between BASE (c9a270d) and HEAD (3eb6493). Click for more details.

HEAD has 1 upload less than BASE
Flag BASE (c9a270d) HEAD (3eb6493)
pytests 1 0
Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #8485      +/-   ##
===========================================
- Coverage    67.34%   60.53%   -6.82%     
===========================================
  Files          780      543     -237     
  Lines        59523    38427   -21096     
  Branches     10142    10142              
===========================================
- Hits         40087    23260   -16827     
+ Misses       19433    15164    -4269     
  Partials         3        3              
Flag Coverage Ξ”
lsf-e2e 54.68% <ΓΈ> (+0.01%) ⬆️
lsf-integration 51.30% <ΓΈ> (+0.02%) ⬆️
lsf-unit 8.60% <ΓΈ> (ΓΈ)
pytests ?

Flags with carried forward coverage won't be shown. Click here to find out more.

β˜” View full report in Codecov by Sentry.
πŸ“’ Have feedback on the report? Share it here.

πŸš€ New features to boost your workflow:
  • πŸ“¦ JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@farioas farioas merged commit 63237a5 into develop Sep 22, 2025
61 of 66 checks passed
@robot-ci-heartex robot-ci-heartex deleted the fb-echo-413/remove-lso-server-dependency-from-e2e-workflow branch September 22, 2025 09:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants