Skip to content

Commit 76892d3

Browse files
committed
readme - Updating Packages in Samples
1 parent 387cefb commit 76892d3

File tree

2 files changed

+36
-40
lines changed

2 files changed

+36
-40
lines changed

README.md

Lines changed: 7 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -175,20 +175,17 @@ NOTE this will re-generate the Readme.md file in the new sample
175175
To learn more about **Ignite UI for React** components, check out the [React documentation](https://www.infragistics.com/products/ignite-ui-react/react/components/general-getting-started.html).
176176

177177

178-
# Updating Version of IgniteUI Packages
178+
## Updating Packages in Samples
179179

180-
Perform these steps to update version of **Ignite UI for React** packages in all samples. NOTE that the order of these steps is very important.
180+
NOTE Do NOT find replace version of packages in package.json files.
181181

182182
- open this repo in VS Code
183-
- open [gulp-samples.js](./browser/tasks/gulp-samples.js) file
183+
- open [./browser/tasks/gulp-samples.js](./browser/tasks/gulp-samples.js) file
184184
- navigate to the `updateIG` function
185-
- change version of **Ignite UI for React** packages in the `packageUpgrades` array
185+
- update version of packages in `packageUpgrades` array
186186
- open terminal window
187187
- run `cd browser` command
188-
- run `gulp updateIG` command
188+
- run the `gulp updateIG` command
189189
- run `npm install --legacy-peer-deps` command
190-
- create pull request with your changes
191-
- open the [Igniteui-xplat-example](https://github.com/IgniteUI/igniteui-xplat-examples) repo in VS Code
192-
- update version of **Ignite UI for React** packages in [React template](https://github.com/IgniteUI/igniteui-xplat-examples/blob/23.2.x/editor-templates/React/main-template/package.json)
193-
- create pull request with your changes in [Igniteui-xplat-example](https://github.com/IgniteUI/igniteui-xplat-examples) repo
194-
190+
- create AND merge a pull request with changes in all package.json files in this repository
191+
- create 2nd pull request with similar changes in `/editor-templates/react/main-template/package.json` of the [igniteui-xplat-examples](https://github.com/IgniteUI/igniteui-xplat-examples) repository.

browser/tasks/gulp-samples.js

Lines changed: 29 additions & 30 deletions
Original file line numberDiff line numberDiff line change
@@ -824,38 +824,37 @@ function updateIG(cb) {
824824
// { name: "igniteui-react-charts", version: "16.16.2" }, // npm
825825
let packageUpgrades = [
826826
// these IG packages are often updated:
827-
{ name: "igniteui-react-core" , version: "18.7.4" },
828-
{ name: "igniteui-react-charts" , version: "18.7.4" },
829-
{ name: "igniteui-react-excel" , version: "18.7.4" },
830-
{ name: "igniteui-react-gauges" , version: "18.7.4" },
831-
{ name: "igniteui-react-grids" , version: "18.7.4" },
832-
{ name: "igniteui-react-inputs" , version: "18.7.4" },
833-
{ name: "igniteui-react-layouts" , version: "18.7.4" },
834-
{ name: "igniteui-react-maps" , version: "18.7.4" },
835-
{ name: "igniteui-react-spreadsheet-chart-adapter", version: "18.7.4" },
836-
{ name: "igniteui-react-spreadsheet" , version: "18.7.4" },
837-
{ name: "igniteui-react-datasources" , version: "18.7.4" },
838-
{ name: "igniteui-react" , version: "18.7.4" },
827+
{ version: "18.7.4", name: "igniteui-react-core" },
828+
{ version: "18.7.4", name: "igniteui-react-charts" },
829+
{ version: "18.7.4", name: "igniteui-react-excel" },
830+
{ version: "18.7.4", name: "igniteui-react-gauges" },
831+
{ version: "18.7.4", name: "igniteui-react-grids" },
832+
{ version: "18.7.4", name: "igniteui-react-inputs" },
833+
{ version: "18.7.4", name: "igniteui-react-layouts" },
834+
{ version: "18.7.4", name: "igniteui-react-maps" },
835+
{ version: "18.7.4", name: "igniteui-react-spreadsheet-chart-adapter" },
836+
{ version: "18.7.4", name: "igniteui-react-spreadsheet" },
837+
{ version: "18.7.4", name: "igniteui-react-datasources" },
838+
{ version: "18.7.4", name: "igniteui-react" },
839839
// these IG packages are sometimes updated:
840-
{ name: "igniteui-webcomponents", version: "5.1.2" },
841-
{ name: "igniteui-dockmanager", version: "1.15.2" },
840+
{ version: "5.1.2" , name: "igniteui-webcomponents" },
841+
{ version: "1.15.2", name: "igniteui-dockmanager" },
842842
// main react packages
843-
{ name: "react" , version: "^18.2.0", },
844-
{ name: "react-dom" , version: "^18.2.0", },
845-
{ name: "react-scripts" , version: "^5.0.1", },
846-
// { name: "tslib" , version: "^2.4.0", },
847-
// { name: "lit-html" , version: "^2.2.0", },
848-
849-
{ name: "eslint" , version: "^8.33.0", },
850-
{ name: "eslint-config-react", version: "^1.1.7", },
851-
{ name: "eslint-plugin-react", version: "^7.20.0", },
852-
853-
{ name: "@types/jest" , version: "^29.2.0", },
854-
{ name: "@types/node" , version: "^18.11.7", },
855-
{ name: "@types/react" , version: "^18.0.24", },
856-
{ name: "@types/react-dom" , version: "^18.0.8", },
857-
{ name: "react-app-rewired" , version: "^2.2.1", },
858-
{ name: "typescript" , version: "^4.8.4", },
843+
{ version: "^18.2.0", name: "react" },
844+
{ version: "^18.2.0", name: "react-dom" },
845+
{ version: "^5.0.1", name: "react-scripts" },
846+
// { version: "^2.4.0", name: "tslib" },
847+
// { version: "^2.2.0", name: "lit-html" },
848+
{ version: "^8.33.0", name: "eslint" },
849+
{ version: "^1.1.7", name: "eslint-config-react" },
850+
{ version: "^7.20.0", name: "eslint-plugin-react" },
851+
852+
{ version: "^29.2.0", name: "@types/jest" },
853+
{ version: "^18.11.7", name: "@types/node" },
854+
{ version: "^18.0.24", name: "@types/react" },
855+
{ version: "^18.0.8", name: "@types/react-dom" },
856+
{ version: "^2.2.1", name: "react-app-rewired" },
857+
{ version: "^4.8.4", name: "typescript" },
859858
];
860859

861860
// NOTE you can comment out strings in this array to run these function only on a subset of samples

0 commit comments

Comments
 (0)