Merge pull request #797 from oflebbe/glyph

RobLoach · web-flow · commit e5e427030fa0 · 2025-03-29T23:12:09.000-04:00
fix: unintialized data in glyph
diff --git a/clib.json b/clib.json
@@ -1,6 +1,6 @@
 {
   "name": "nuklear",
-  "version": "4.12.5",
+  "version": "4.12.6",
   "repo": "Immediate-Mode-UI/Nuklear",
   "description": "A small ANSI C gui toolkit",
   "keywords": ["gl", "ui", "toolkit"],
diff --git a/nuklear.h b/nuklear.h
@@ -18304,7 +18304,7 @@ nk_input_glyph(struct nk_context *ctx, const nk_glyph glyph)
 NK_API void
 nk_input_char(struct nk_context *ctx, char c)
 {
-    nk_glyph glyph;
+    nk_glyph glyph = {0};
     NK_ASSERT(ctx);
     if (!ctx) return;
     glyph[0] = c;
@@ -30700,6 +30700,7 @@ nk_tooltipfv(struct nk_context *ctx, const char *fmt, va_list args)
 ///   - [y]: Minor version with non-breaking API and library changes
 ///   - [z]: Patch version with no direct changes to the API
 ///
+/// - 2025/03/29 (4.12.6) - Fix unitialized data in nk_input_char
 /// - 2025/03/05 (4.12.5) - Fix scrolling knob also scrolling parent window, remove dead code
 /// - 2024/12/11 (4.12.4) - Fix array subscript [0, 0] is outside array bounds of ‘char[1]’
 /// - 2024/12/11 (4.12.3) - Fix border color for property widgets
diff --git a/src/CHANGELOG b/src/CHANGELOG
@@ -7,6 +7,7 @@
 ///   - [y]: Minor version with non-breaking API and library changes
 ///   - [z]: Patch version with no direct changes to the API
 ///
+/// - 2025/03/29 (4.12.6) - Fix unitialized data in nk_input_char
 /// - 2025/03/05 (4.12.5) - Fix scrolling knob also scrolling parent window, remove dead code
 /// - 2024/12/11 (4.12.4) - Fix array subscript [0, 0] is outside array bounds of ‘char[1]’
 /// - 2024/12/11 (4.12.3) - Fix border color for property widgets
diff --git a/src/nuklear_input.c b/src/nuklear_input.c
@@ -124,7 +124,7 @@ nk_input_glyph(struct nk_context *ctx, const nk_glyph glyph)
 NK_API void
 nk_input_char(struct nk_context *ctx, char c)
 {
-    nk_glyph glyph;
+    nk_glyph glyph = {0};
     NK_ASSERT(ctx);
     if (!ctx) return;
     glyph[0] = c;

Original file line number	Diff line number	Diff line change
`@@ -1,6 +1,6 @@`
`1`	`1`	`{`
`2`	`2`	`"name": "nuklear",`
`3`		`- "version": "4.12.5",`
	`3`	`+ "version": "4.12.6",`
`4`	`4`	`"repo": "Immediate-Mode-UI/Nuklear",`
`5`	`5`	`"description": "A small ANSI C gui toolkit",`
`6`	`6`	`"keywords": ["gl", "ui", "toolkit"],`
Original file line number	Diff line number	Diff line change
`@@ -124,7 +124,7 @@ nk_input_glyph(struct nk_context *ctx, const nk_glyph glyph)`
`124`	`124`	`NK_API void`
`125`	`125`	`nk_input_char(struct nk_context *ctx, char c)`
`126`	`126`	`{`
`127`		`- nk_glyph glyph;`
	`127`	`+ nk_glyph glyph = {0};`
`128`	`128`	`NK_ASSERT(ctx);`
`129`	`129`	`if (!ctx) return;`
`130`	`130`	`glyph[0] = c;`