Skip to content

Commit 1a4f450

Browse files
Merge move_elementwise_binary_impl_part_3 into finalize_functional_migration
2 parents f4c05d2 + d00ebe4 commit 1a4f450

Some content is hidden

Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.

50 files changed

+221
-151
lines changed

.github/workflows/conda-package.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -37,7 +37,7 @@ jobs:
3737
actions: write
3838

3939
runs-on: ${{ matrix.os }}
40-
timeout-minutes: 60
40+
timeout-minutes: 80
4141

4242
defaults:
4343
run:

dpctl_ext/tensor/libtensor/include/kernels/elementwise_functions/angle.hpp

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -32,6 +32,7 @@
3232
/// This file defines kernels for elementwise evaluation of ANGLE(x) function.
3333
//===---------------------------------------------------------------------===//
3434

35+
#pragma once
3536
#include <complex>
3637
#include <cstddef>
3738
#include <cstdint>

dpctl_ext/tensor/libtensor/include/kernels/elementwise_functions/atan2.hpp

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -34,6 +34,7 @@
3434
//===---------------------------------------------------------------------===//
3535

3636
#pragma once
37+
#include <cmath>
3738
#include <cstddef>
3839
#include <cstdint>
3940
#include <type_traits>

dpctl_ext/tensor/libtensor/include/kernels/elementwise_functions/bitwise_and.hpp

Lines changed: 0 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -54,7 +54,6 @@ namespace dpctl::tensor::kernels::bitwise_and
5454

5555
using dpctl::tensor::ssize_t;
5656
namespace td_ns = dpctl::tensor::type_dispatch;
57-
namespace tu_ns = dpctl::tensor::type_utils;
5857

5958
template <typename argT1, typename argT2, typename resT>
6059
struct BitwiseAndFunctor
@@ -67,8 +66,6 @@ struct BitwiseAndFunctor
6766

6867
resT operator()(const argT1 &in1, const argT2 &in2) const
6968
{
70-
using tu_ns::convert_impl;
71-
7269
if constexpr (std::is_same_v<resT, bool>) {
7370
return in1 && in2;
7471
}
@@ -296,8 +293,6 @@ struct BitwiseAndInplaceFunctor
296293

297294
void operator()(resT &res, const argT &in) const
298295
{
299-
using tu_ns::convert_impl;
300-
301296
if constexpr (std::is_same_v<resT, bool>) {
302297
res = res && in;
303298
}

dpctl_ext/tensor/libtensor/include/kernels/elementwise_functions/bitwise_invert.hpp

Lines changed: 0 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -47,16 +47,12 @@
4747
#include "kernels/elementwise_functions/common.hpp"
4848

4949
#include "utils/type_dispatch_building.hpp"
50-
#include "utils/type_utils.hpp"
5150

5251
namespace dpctl::tensor::kernels::bitwise_invert
5352
{
5453

5554
using dpctl::tensor::ssize_t;
5655
namespace td_ns = dpctl::tensor::type_dispatch;
57-
namespace tu_ns = dpctl::tensor::type_utils;
58-
59-
using dpctl::tensor::type_utils::vec_cast;
6056

6157
template <typename argT, typename resT>
6258
struct BitwiseInvertFunctor

dpctl_ext/tensor/libtensor/include/kernels/elementwise_functions/bitwise_or.hpp

Lines changed: 0 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -54,7 +54,6 @@ namespace dpctl::tensor::kernels::bitwise_or
5454

5555
using dpctl::tensor::ssize_t;
5656
namespace td_ns = dpctl::tensor::type_dispatch;
57-
namespace tu_ns = dpctl::tensor::type_utils;
5857

5958
template <typename argT1, typename argT2, typename resT>
6059
struct BitwiseOrFunctor
@@ -67,8 +66,6 @@ struct BitwiseOrFunctor
6766

6867
resT operator()(const argT1 &in1, const argT2 &in2) const
6968
{
70-
using tu_ns::convert_impl;
71-
7269
if constexpr (std::is_same_v<resT, bool>) {
7370
return in1 || in2;
7471
}
@@ -296,8 +293,6 @@ struct BitwiseOrInplaceFunctor
296293

297294
void operator()(resT &res, const argT &in) const
298295
{
299-
using tu_ns::convert_impl;
300-
301296
if constexpr (std::is_same_v<resT, bool>) {
302297
res = res || in;
303298
}

dpctl_ext/tensor/libtensor/include/kernels/elementwise_functions/bitwise_xor.hpp

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -54,7 +54,6 @@ namespace dpctl::tensor::kernels::bitwise_xor
5454

5555
using dpctl::tensor::ssize_t;
5656
namespace td_ns = dpctl::tensor::type_dispatch;
57-
namespace tu_ns = dpctl::tensor::type_utils;
5857

5958
template <typename argT1, typename argT2, typename resT>
6059
struct BitwiseXorFunctor
@@ -297,8 +296,6 @@ struct BitwiseXorInplaceFunctor
297296

298297
void operator()(resT &res, const argT &in) const
299298
{
300-
using tu_ns::convert_impl;
301-
302299
if constexpr (std::is_same_v<resT, bool>) {
303300
res = (res != in);
304301
}

dpctl_ext/tensor/libtensor/include/kernels/elementwise_functions/cbrt.hpp

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -30,7 +30,7 @@
3030
///
3131
/// \file
3232
/// This file defines kernels for elementwise evaluation of CBRT(x)
33-
/// function that compute a square root.
33+
/// function that computes a cube root.
3434
//===---------------------------------------------------------------------===//
3535

3636
#pragma once

dpctl_ext/tensor/libtensor/include/kernels/elementwise_functions/common.hpp

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -35,6 +35,7 @@
3535
#include <algorithm>
3636
#include <cstddef>
3737
#include <cstdint>
38+
#include <iterator>
3839
#include <type_traits>
3940
#include <vector>
4041

dpctl_ext/tensor/libtensor/include/kernels/elementwise_functions/equal.hpp

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -34,6 +34,7 @@
3434
//===---------------------------------------------------------------------===//
3535

3636
#pragma once
37+
#include <complex>
3738
#include <cstddef>
3839
#include <cstdint>
3940
#include <type_traits>
@@ -47,7 +48,6 @@
4748
#include "kernels/dpctl_tensor_types.hpp"
4849
#include "kernels/elementwise_functions/common.hpp"
4950

50-
#include "utils/offset_utils.hpp"
5151
#include "utils/type_dispatch_building.hpp"
5252
#include "utils/type_utils.hpp"
5353

0 commit comments

Comments
 (0)