Issue with flatlaf-jide-oss customizations of JideButton

[acepe]

Hi,

I have encountered a small issue with DateChoosePane from jidesoft (payed version, not part of jide-oss), wenn using the flatlaf customizations from com.formdev.flatlaf-jide-oss.

Flatlaf-jide-oss introduces customizations for JideButton:

JideButton.border = com.formdev.flatlaf.ui.FlatMarginBorder
[…]
JideButton.background = $Button.background
JideButton.foreground = $Button.foreground
JideButton.focusedBackground = $Button.toolbar.hoverBackground
JideButton.selectedBackground = $Button.toolbar.selectedBackground
JideButton.selectedAndFocusedBackground = $Button.toolbar.pressedBackground
JideButton.borderColor = $Button.borderColor
[…]

The problem is, that JideButtons are used for displaying and selecting dates in the DateChooserPane. Due to using FlatMarginBorder and white-on-white background the selected date is not visible anymore.

Original, without including flatlaf-jide-oss:

When including flatlaf-jide-oss:

I was wondering, is there a reason you are using $Button.toolbar.hoverBackground, instead of $Button.hoverBackground (same for selected and pressed variants)?
Because when taking the styles from $Button directly, it looks somewhat acceptable, even without the border:

[DevCharly]

I was wondering, is there a reason you are using $Button.toolbar.hoverBackground, instead of $Button.hoverBackground...

Because JideButton is intended to be used in toolbars and JIDE command bars. See Javadoc of JideButton:

JideButton is a replacement for JButton when it is used on toolbar (or command bar in the case of JIDE Action Framework).
https://github.com/jidesoft/jide-oss/blob/07442fc834f81e672fc35ef9793b07c395b6e37e/src/com/jidesoft/swing/JideButton.java#L17-L18

Here is a comparison of FlatLaf and Windows Laf for all JideBtton styles, which looks pretty good/equal:

When I compare your first two screenshots, then the various background colors look the same,
but the border is missing for selected and hover dates...

Not sure where this border is painted...
Maybe there is something missing in FlatJidePainter...
And where does the red border for today come from?