-
-
Notifications
You must be signed in to change notification settings - Fork 3.1k
Combine SearchableComboBox and TextField for adding fields in Custom Entry Types #14549
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
…into fix-for-issue-14547
|
In general I like this; however, the drawback is that you need to know the field names to search for... |
CHANGELOG.md
Outdated
| - The URL integrity check now checks the complete URL syntax. [#14370](https://github.com/JabRef/jabref/pull/14370) | ||
| - <kbd>Tab</kbd> in the last text field of a tab moves the focus to the next tab in the entry editor. [#11937](https://github.com/JabRef/jabref/issues/11937) | ||
| - We changed fixed-value ComboBoxes to SearchableComboBox for better usability. [#14083](https://github.com/JabRef/jabref/issues/14083) | ||
| - We combined the SearchableComboBox and the TextField for adding fields in Custom Entry Types. [#14547](https://github.com/JabRef/jabref/issues/14547) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is not user-facing - which user knows what a "SearchableComboBox" is - this is not a word from an English dictionary. - Please rephrase.
jabgui/src/main/resources/org/jabref/gui/preferences/customentrytypes/CustomEntryTypesTab.fxml
Outdated
Show resolved
Hide resolved
…rytypes/CustomEntryTypesTab.fxml
|
JUnit tests of You can then run these tests in IntelliJ to reproduce the failing tests locally. We offer a quick test running howto in the section Final build system checks in our setup guide. |
Closes #14547
This pull request replaces the separate mechanisms (SearchableComboBox and free TextField) for adding new fields with a single TextField utilizing auto-completion in the "Custom Entry Types" preference pane.
This improves usability by unifying the workflow: users can quickly filter and find a standard field or type a custom field name directly in the same control. The option is located under
File -> Preferences -> Entry types.Steps to test the combined input field
File -> Preferences -> Entry types.+button.+button is enabled.+to add it.Final Result
Mandatory checks
CHANGELOG.mdin a way that is understandable for the average user (if change is visible to the user)