feat(media): truncate media label with consideration of full-width characters #505
+25
−5
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, all characters were treated as 1 unit wide, which caused incorrect truncation for certain characters, such as CJK characters. This resulted in media labels being longer than expected when compared to ASCII characters.
For instance, when the "Media - Truncation Size" is set to 30, the truncation works correctly for alphabetic characters, displaying up to 30 characters. However, for CJK characters, each character was counted as 1 unit, causing the truncation to display approximately twice the width compared to 30 alphabetic characters.
This commit introduces a Regex solution to count full-width characters as 2 units in length. While this approach may not cover every possible full-width character, it should be sufficient for most common scenarios.